Repository navigation
Use SqlBuilder for NGO list sorting and allow sorting by NumberOfStaff - #1112
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/ngosquery with DapperSqlBuilder(same pattern as the form-submissions list endpoints) instead ofCASE WHEN @sortExpression = ...sorting.NumberOfStaffas a sortable column./**where**/clauses only when provided; count and page queries share them.ORDER BYclause; unknown/empty columns fall back toName ASC(previously an unknown column fell back toName DESC, and an explicitNamesort ignored the requested direction).Test plan