docs: sync the action logo with the new org branding - #259
Merged
Conversation
The comment header and the two README previews embed assets/logo.png at width="20". That file was still the old wordmark — a 128x128 badge with "COMMIT" set across it — while the org rebranded to a wordless mark in commit-check/.github#49. At the size it is actually displayed the wordmark is unreadable, which is the reason the new avatar dropped the text in the first place; the branding README says so directly: "GitHub shows org avatars at around 40px in most places, and at that size a wordmark is an unreadable smudge." The header renders at half that again. Re-rendered from branding/logo-mark.png, the asset that README nominates for "the mark alone, transparent, where a background already exists" — which is exactly the case here, since the mark sits on the comment's own background. Downscaled 1024 -> 128 with Lanczos, keeping the file's existing dimensions so nothing that references it has to change. Measured on the result: RGBA preserved (alpha extrema 0-255, so the transparent ground survived rather than being flattened to white), and the dominant opaque colour is (44, 156, 205) = #2c9ccd, the brand colour the branding README documents. 4994 -> 3001 bytes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
shenxianpeng
added a commit
that referenced
this pull request
Aug 7, 2026
#259 swapped the old wordmark badge for the org's new mark, which was the right art but the wrong variant for this surface. The header renders the image at 20px, and the wordless mark is a stroke on transparency -- at that size a stroke carries almost no visual weight, so the header read as a faint tick rather than a mark. It is worst on GitHub's dark theme, where a thin brand-blue line sits close to the background. Two things were wrong, not one: * The variant. branding/logo-mark.png is documented for use "where a background already exists"; the comment header has none, so the mark had nothing to sit on. branding/avatar.png is the filled version and the one the branding README calls out as legible small. Using it here is what the asset is for. * The size. The report title is an h2, which GitHub renders at about 24px, so a 20px icon was smaller than the words beside it and lost the visual hierarchy before any question of contrast. So assets/logo.png is now a 128x128 downscale of avatar.png with the corners rounded (22%), and the width goes 20 -> 24 to match the h2 cap height. Rounding matters because GitHub rounds avatars in its own UI but not inline images; without it the header carries a hard blue square. Measured on the written file: RGBA preserved with the corners genuinely transparent (alpha 0 at 0,0 -- a flattened export would have shown 255 and rendered as a white box on dark), and the two dominant opaque colours are (44,156,205) = #2c9ccd and white, i.e. the brand blue and the check. 4994 -> 2822 bytes. Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
assets/logo.pngwas still the old wordmark — a 128×128 badge with "COMMIT" set across the check — while the org moved to a wordless mark in commit-check/.github#49.This file is embedded at
width="20"in three places — the comment header built inmain.py:40, and the two README previews (README.md:243,:267). At 20px the wordmark is an unreadable smudge, which is precisely why the new avatar dropped the text. The branding README says it outright:The comment header renders at half that again.
What changed
One binary file. Re-rendered from
branding/logo-mark.png, the asset the branding README nominates for "the mark alone, transparent, where a background already exists" — exactly this case, since the mark sits on the comment's own background rather than carrying its own.Downscaled 1024 → 128 with Lanczos, keeping the existing dimensions so nothing referencing the file has to change.
Verification
Measured on the written file, not assumed:
RGBA, alpha extrema(0, 255). A flattened export would have shown a255floor and rendered as a white box on dark themes, the exact defect the branding README flags about the legacylogo-small.jpg.(44, 156, 205)=#2c9ccd, the value the branding README documents.No code, workflow, or README text changes; the three references keep working untouched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
Generated by Claude Code