Skip to content

feat(wallet-mcp): add QHooks read and prepare plugin - #24

Draft
qhooks wants to merge 2 commits into
coinbase:mainfrom
qhooks:qhooks-wallet-mcp-plugin
Draft

qhooks wants to merge 2 commits into
coinbase:mainfrom
qhooks:qhooks-wallet-mcp-plugin

Conversation

@qhooks

@qhooks qhooks commented Nov 16, 2026 •

Copy link
Copy Markdown

Description

Add an opt-in QHooks plugin at skills/wallet-mcp/plugins/qhooks.md. QHooks' public MCP supplies market/stored-QProof reads and unsigned EVM plans; Wallet MCP handles the user's approval and submission through send_calls.

The spec reads the live QHooks tool catalog instead of maintaining a duplicate list. It covers exact unit/actor/chain validation, ordered approval/action batches, staged approvals, and original-request reconciliation. Its executable mapping example rejects unsafe integer values, stale plans, unsupported networks, launch links and perps typed-data payloads. Launch links and perps signing stay in their appropriate QHooks/site flow. No signer, key, executor, new API dependency, paid service or generated distribution is added. Feedback/posts are not sent as part of read/prepare flows.

This uses the current Wallet MCP source location. base/skills removed base-mcp and wallet-mcp; the current CDP documentation points to this repository. No deprecated duplicate is added.

Change type

  • Harness integration or metadata
  • Skill workflow
  • Bug fix
  • Documentation
  • Breaking change (describe migration)

Validation

  • python3 scripts/build-distributions.py dist — passed. Current selected distributions remain unchanged; Wallet MCP is source-only and this PR does not activate it in generated packages.
  • python3 -m unittest discover -s tests — 38 passed.
  • Seven focused local checks — passed: shared QHooks discovery metadata/catalog parity; current plugin section/routing contract; exact Base/BNB/RH mapping; large integer handling; staged approval preservation; actual unsigned contract shape for unfunded OTC and agreement actions; rejection of inconsistent actors/chains, expired plans, unsupported networks, launch links and perps payloads.
  • QHooks compiled workerd preview — unchanged 26-tool live catalog, matching discovery summary, exact Markdown asset, zero outbound requests or wallet calls.
  • QHooks-side 188-route comparison — zero dropped or required-missing routes.
  • Live conformance used only QHooks MCP initialize/tools-list metadata, never prepare, feedback or wallet execution calls.

The plugin-review utility referenced by plugin-spec.md is absent from the current repository. Self-review used the canonical frontmatter/section/routing checklist and the focused executable-example tests; no unavailable utility run is claimed. Native Coinbase Wallet onboarding, approval and financial execution were not exercised.

  • Generated portable manifest and MCP config validate against the vendored Agent Plugins schemas
  • Package paths and skill references remain inside each generated plugin root
  • Marketplace, skills, MCP, and icon paths are valid
  • Exactly one canonical skill library; generated copies are not committed
  • Claude compatibility metadata/endpoint and marketplace sources agree with the portable package
  • Tool schemas, authorization, and retry behavior reviewed
  • README and changelog updated; versions consistent
  • No unapproved disclosures or sensitive data
  • Signed commits

README/changelog and maintainer-owned plugin tables are unchanged to honor the more specific Contribution Scope in skills/wallet-mcp/references/plugin-spec.md: only the plugin file is added; existing tag vocabulary is reused. No package version changes are needed for a source-only plugin doc.

Release considerations

Draft for maintainer review. This is a third-party custom plugin, not an endorsed or hosted-allowlisted integration. It does not add the Wallet MCP product to the router or any distribution. QHooks service flags and current schemas remain authoritative. The user selects QHooks, reviews each plan and approves each wallet action; unknown outcomes never trigger a fresh batch.

Add an opt-in external MCP specification for public reads and user-approved EVM plans. Preserve ordered exact calls and the current wallet approval boundary. No signer, executor, key, paid service or product distribution is added.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
1 if authored by an app that is not allowlisted and lacks verified human attribution 0
Sum 1

Handle unfunded OTC creation and explicit transaction-level chain IDs for agreement actions. Reject inconsistent actors, mixed chains and failed simulations. No signing or submission logic.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants