Repository navigation
Conversation
Add an opt-in external MCP specification for public reads and user-approved EVM plans. Preserve ordered exact calls and the current wallet approval boundary. No signer, executor, key, paid service or product distribution is added.
🟡 Heimdall Review Status
|
Handle unfunded OTC creation and explicit transaction-level chain IDs for agreement actions. Reject inconsistent actors, mixed chains and failed simulations. No signing or submission logic.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an opt-in QHooks plugin at
skills/wallet-mcp/plugins/qhooks.md. QHooks' public MCP supplies market/stored-QProof reads and unsigned EVM plans; Wallet MCP handles the user's approval and submission throughsend_calls.The spec reads the live QHooks tool catalog instead of maintaining a duplicate list. It covers exact unit/actor/chain validation, ordered approval/action batches, staged approvals, and original-request reconciliation. Its executable mapping example rejects unsafe integer values, stale plans, unsupported networks, launch links and perps typed-data payloads. Launch links and perps signing stay in their appropriate QHooks/site flow. No signer, key, executor, new API dependency, paid service or generated distribution is added. Feedback/posts are not sent as part of read/prepare flows.
This uses the current Wallet MCP source location.
base/skillsremovedbase-mcpandwallet-mcp; the current CDP documentation points to this repository. No deprecated duplicate is added.Change type
Validation
python3 scripts/build-distributions.py dist— passed. Current selected distributions remain unchanged; Wallet MCP is source-only and this PR does not activate it in generated packages.python3 -m unittest discover -s tests— 38 passed.The
plugin-reviewutility referenced by plugin-spec.md is absent from the current repository. Self-review used the canonical frontmatter/section/routing checklist and the focused executable-example tests; no unavailable utility run is claimed. Native Coinbase Wallet onboarding, approval and financial execution were not exercised.README/changelog and maintainer-owned plugin tables are unchanged to honor the more specific Contribution Scope in
skills/wallet-mcp/references/plugin-spec.md: only the plugin file is added; existing tag vocabulary is reused. No package version changes are needed for a source-only plugin doc.Release considerations
Draft for maintainer review. This is a third-party custom plugin, not an endorsed or hosted-allowlisted integration. It does not add the Wallet MCP product to the router or any distribution. QHooks service flags and current schemas remain authoritative. The user selects QHooks, reviews each plan and approves each wallet action; unknown outcomes never trigger a fresh batch.