Repository navigation
Agent installer: run the launchd agent at standard priority - #25
Merged
Merged
Conversation
A Background launchd job runs in the lowest scheduling band. On a busy Mac the agent process starved for over a minute, missed its check-ins, was marked offline and had its running jobs requeued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS installer registers the agent with
ProcessType=Background. launchd then runs it (and every CLI session it spawns) in the lowest scheduling band. On a Mac under load (load average around 45 on 14 cores) the agent process did not get scheduled for about 100 seconds: no check-in reached the server, the agent was marked offline after 45 seconds and its two running jobs were requeued. The results it reported afterwards were rejected with HTTP 409.Change
Use
ProcessType=Standardin the generated LaunchAgent.Verified
Existing installs keep their plist until they are reinstalled.