Let overridden readers supply locale fallback - #2464
Merged
Conversation
Resolving a translated attribute for a locale without translation read the raw column, so host apps that override such an attribute's reader to compute a default lost that default everywhere. Sites without an explicitly configured privacy URL, for instance, rendered no privacy link at all. Reading through the reader instead restores that extension point for all consumers at once; an explicit per locale translation still takes precedence. An overridden reader must not call `translated` itself, since that would recurse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving a translated attribute for a locale without translation read the raw column, so host apps that override such an attribute's reader to compute a default lost that default everywhere. Sites without an explicitly configured privacy URL, for instance, rendered no privacy link at all. Reading through the reader instead restores that extension point for all consumers at once; an explicit per locale translation still takes precedence.
An overridden reader must not call
translateditself, since that would recurse.