Repository navigation
fix: report an unconfirmed save without claiming it failed - #575
Merged
Merged
Conversation
…into fix/save-response-uncertainty/core # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #569.
When a save produced no response, the editor reported "Could not update snippet. The request did not reach your site." Neither half is knowable from a missing response: the request may have been handled and the response lost on the way back, in which case the snippet is saved and the reader has just been told it is not.
The no-response case is now reported as an unconfirmed outcome, and is no longer placed behind the heading stating the snippet was not saved. The reader is pointed at checking the saved version before saving again, rather than being told to retry.
Responses that did arrive are unchanged, including the signed-out case and server errors.
Verification
lint:jspasses with no new warnings.