Repository navigation
fix: apply the truncation screen option to snippet descriptions - #573
Merged
Merged
Conversation
ramiy
approved these changes
Oct 3, 2026
…into fix/description-truncation/core # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #556.
Turning off "Truncate long snippet names and descriptions" expanded snippet names but left descriptions clipped with an ellipsis.
Two rules targeted the description cell at equal specificity, so source order decided between them: one in
common/list-table/_layout.scssapplied only while the option was on, and one inmanage/_snippets-table.scssclamped the cell to two lines for every row regardless of the option. The later, unconditional rule won, so the description stayed clamped whatever the option said.That clamp is now scoped to the option, alongside the rule governing names. Appearance with the option on is unchanged.
Verification
2while the option is on andnoneonce it is off, and the description no longer hides any of its own height. It fails without the change.lint:stylesandlint:jspass.