Repository navigation
fix: guard the Elementor promotion against older control types - #571
Merged
Merged
Conversation
sheabunge
approved these changes
Sep 30, 2026
ramiy
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #567.
The Elementor Custom CSS promotion registers its control with the
NOTICEcontrol type, which Elementor added in 3.19. On an older Elementor the constant does not exist, and it is read while the editor builds its controls, so the editor fatals and becomes unusable.The promotion is now skipped when that control type is unavailable: no fatal and no banner on older versions, unchanged behaviour on current ones.
Verification
defined()resolves a class constant to true when present, false when the constant is missing, and false without raising when the class is absent.lint:phppass.