Repository navigation
🤖 fix: a held annotate shortcut toggles artifact annotate mode once - #6631
Merged
Merged
Conversation
The panel's annotate shortcut reacted to every auto-repeated keydown, so a held key toggled annotate mode at the key-repeat rate. Ignore repeats, as the frame's key bridge already does. Refs #6347
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Holding the annotate shortcut (
KEYBINDS.TOGGLE_ARTIFACT_ANNOTATE) on the Artifacts panel toggled annotate mode at the key-repeat rate. The panel now ignores auto-repeated keydowns for that shortcut, so a held key toggles the mode once.Fixes #6347
Background
#6341 made the same shortcut work from inside an HTML or SVG artifact frame. That frame path already ignores
event.repeat, because a held key would also spend the frame's bridge message budget. The panel's own handler had no such check, so the two paths behaved differently. This was cosmetic and existed before #6341.Implementation
ArtifactsPanel.tsx: a smallmatchesAnnotateShortcuthelper returns false fore.repeat. The panel'shandleKeyDownuses it for the annotate branch. Other panel shortcuts are unchanged.Validation
ArtifactsPanel.test.tsx, "a held annotate shortcut toggles annotate mode once": one press turns annotate mode on, two repeated keydowns leave it on, and the next press turns it off. Removing thee.repeatcheck makes this test fail.make crap-checkpasses with 0 violations. It warns thatArtifactsPanelis a large function this PR touches, and its complexity is unchanged.Risks
Very low. The change only skips repeated keydowns for one single-key shortcut on the Artifacts panel.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$15.40