Extending te_variable functions - #126
Closed
loumalouomega wants to merge 2 commits into
Closed
Conversation
Author
|
Hello |
Author
|
Greetings |
Owner
|
Thanks for the patch. Comparison as zIsGreater(a,b) functions overlaps with the logic branch, which does this as real operators, and the z-prefix naming is driven by the alphabetical lookup rather than by what's good to type. Closing, see CONTRIBUTING. TinyExpr is small enough that you can add this yourself in a fork. It only stays that way if I don't implement every request like this one. |
Author
|
OKay, I just wanted to contribute with the changes we applied in our system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding:
{"zIsEqual", IsEqual, TE_FUNCTION2 | TE_FLAG_PURE, 0}, {"zIsGreater", IsGreater, TE_FUNCTION2 | TE_FLAG_PURE, 0}, {"zIsGreaterEqual", IsGreaterEqual, TE_FUNCTION2 | TE_FLAG_PURE, 0}, {"zIsLess", IsLess, TE_FUNCTION2 | TE_FLAG_PURE, 0}, {"zIsLessEqual", IsLessEqual, TE_FUNCTION2 | TE_FLAG_PURE, 0},This bring the changes we have added to our project https://github.com/KratosMultiphysics/Kratos/