Skip to content

perf(artifacts): decode text once per file #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikeeI wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(artifacts): decode text once per file #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/artifacts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,21 @@ export function inventoryArtifacts(
} catch {
continue; // unreadable — skip, don't crash
}
const text = decodeLossy(raw);
if (!matched) {
// Never drop: a file without a rule is still inventoried. Extensionless shebang files are
// scripts; everything else decodable is `unknown`; undecodable bytes are hash-only.
const probe = decodeLossy(raw);
if (path.extname(base) === "" && raw.subarray(0, 2).toString("utf-8") === "#!") {
format = "text";
roles = ["script"];
} else if (probe === undefined) {
} else if (text === undefined) {
format = "binary";
roles = ["unknown"];
} else {
format = "text";
roles = ["unknown"];
}
}
const text = decodeLossy(raw);
const capture = opts.artifactText ?? true;
const cap = opts.artifactTextMaxBytes ?? DEFAULT_ARTIFACT_TEXT_MAX_BYTES;
const textByteLength = text === undefined ? 0 : Buffer.byteLength(text, "utf8");
Expand Down