chore: track bun.lock so --frozen-lockfile means something - #108
Merged
Conversation
CI has always run `bun install --frozen-lockfile`, but the lockfile was ignored, and bun does not fail on a merely absent one — so the flag was a silent no-op and every run resolved 250 packages fresh from the registry. A green CI run could not say which versions were green. bun.lockb, the superseded binary format, stays ignored. Closes #107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107.
CI has always run
bun install --frozen-lockfile, butbun.lockwas gitignored since the repo'sfirst commit. Bun does not fail on a merely absent lockfile — it installs and moves on — so the
flag was a silent no-op and every CI run resolved its dependencies fresh from the registry. A green
run could not tell you which versions were green, and a transitive publish between two runs changed
what was tested with no diff to show for it.
bun.lockb, the superseded binary format, stays ignored.Verification
Behavioral, on a clean clone of this branch — not a reading of the YAML.
Before, on
main(no lockfile in the checkout):After, on this branch, with drift introduced into
package.json:The same drift was silently installed before this change. The lockfile is also idempotent —
a second
bun installreportsChecked 262 installs across 251 packages (no changes).Note
The blanket
bun.lockpattern this replaces had already caused a separate bug: it swallowedtest/fixtures/artifacts-app/packages/web/bun.lock, whose three sibling lockfiles were tracked,breaking two tests on any clean checkout. That is fixed on
feat/issue-101-artifactswith a!test/fixtures/**/bun.locknegation, which becomes redundant once this lands — worth removingwhen the stack merges, since nothing ignores those paths any more.