Correct the release procedure in RELEASING.md: publishing is automatic - #61
Merged
Conversation
RELEASING.md said release:perform stages to the Central Portal and the release manager then publishes from the Portal UI. That is wrong. maven-release-plugin runs with releaseProfiles=plexus-release, which sets njord.enabled=true. Njord is registered as a build extension and configured with autoPublish=true and publishingType=automatic, so it publishes the deployment itself. Also records that releasing needs Maven 3.9.0, since the plexus-release profile raises minimalMavenBuildVersion above the 3.6.3 an ordinary build requires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60, which I got wrong. Part of #58.
RELEASING.mdsays:There is no such manual step.
maven-release-pluginis configured in the parent POM with<goals>deploy</goals>and<releaseProfiles>plexus-release</releaseProfiles>. Theplexus-releaseprofile setsnjord.enabled=true, and Njord is registered as a build extension with:So
release:performpublishes to Central by itself.njord.enabledisfalseoutside the release profile, so normal builds are unaffected.Telling a release manager to go and finish the job in the Portal UI would have them looking for something that isn't there — which is a worse failure than saying nothing, so worth fixing promptly now that #60 is merged.
Also adds that releasing needs Maven 3.9.0:
plexus-releaseraisesminimalMavenBuildVersionfrom the 3.6.3 an ordinary build needs, so a release run on 3.6.x fails the enforcer.I found this while documenting the parent POM itself (codehaus-plexus/plexus-pom#438), which describes the same mechanism from the other side.