Skip to content

fix(codefresh-run): fix TERMINATE_ON_TIMEOUT - #742

Merged
masontikhonov merged 1 commit into
masterfrom
zhenyatsikhanau/cf-2404-some-builds-got-terminated-due-to
Nov 12, 2026
Merged

masontikhonov merged 1 commit into
masterfrom
zhenyatsikhanau/cf-2404-some-builds-got-terminated-due-to

Conversation

@masontikhonov

@masontikhonov masontikhonov commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

What

This fixes TERMINATE_ON_TIMEOUT behavior broken in 1.6.1 (#740), which caused child build to be never terminated.

New behavior is:

Case Terminates child Step exit code
Timeout, wait exits 1 with the "Operation has timed out" message (CLI <1.3.0) yes 1
Timeout, wait exits 124 (CLI >=1.3.0) yes 124
Timeout, terminate itself fails attempted 1
Other error (e.g. API failure) no 1
Success no 0, next command runs

Contributes to CF-2404

@masontikhonov
masontikhonov merged commit 58781a7 into master Nov 12, 2026
1 check passed
@masontikhonov
masontikhonov deleted the zhenyatsikhanau/cf-2404-some-builds-got-terminated-due-to branch November 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants