Skip to content

Use same Docker image in Codecov steps - #664

Closed
rvanlaak wants to merge 1 commit into
codefresh-io:masterfrom
rvanlaak:patch-1
Closed

rvanlaak wants to merge 1 commit into
codefresh-io:masterfrom
rvanlaak:patch-1

Conversation

@rvanlaak

@rvanlaak rvanlaak commented Dec 7, 2023

Copy link
Copy Markdown

What

  • Reduce the CI execution time needed, as all Docker layers already are cached.
  • Reduce maintenance effort, as the codefresh/cli image will be respected.

Why

... codefresh/cli also is based on Node, and uses Node 18

Notes

... `codefresh/cli` also is based on Node, and uses Node 18
@rvanlaak

Copy link
Copy Markdown
Author

@masontikhonov no valuable feedback on why this gets closed?

@masontikhonov

Copy link
Copy Markdown
Collaborator

@rvanlaak my apologies! I was batch-closing stale PRs, including this one. I should have paid closer attention

I see your request is still relevant and should improve pull time in majority of cases.
Let me see how it fits into the ongoing refactor of CLI; I will get back to you shortly 🙏

@masontikhonov masontikhonov reopened this Nov 12, 2026
@masontikhonov

Copy link
Copy Markdown
Collaborator

Hi @rvanlaak! I double checked, and it seems proposed change will not work. Modern codefresh/cli lacks some utils that are used in the step to verify Codecov binary, such as gpg, gpgv and shasum.

I see no reason however to pull enormous 1.5+Gi node image; let me try to replace it with something smaller in a separate PR.
This one I'm closing though

@rvanlaak

Copy link
Copy Markdown
Author

The reason was mostly because the other step would then use the same image, which in turn reuses the already pulled image layers.

@masontikhonov

Copy link
Copy Markdown
Collaborator

@rvanlaak Please check #752, I hope it will improve situation. It moves required binaries to a dedicated alpine-based image. It's still relatively big due to Codefresh CLI size; however it's already x8.5 times smaller compared to the previous two images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants