KSN: standardize workflow names and add post-merge sanity check - #29
Merged
Merged
Conversation
- rename `Keepalive` to `💓 Keepalive` in `.github/workflows/keepalive.yml`
- rename `.github/workflows/ci.yml` to `.github/workflows/pull-request-checks.yml` - retitle `CI` to `🧪 Pull Request Checks` - broaden `on:` from `push`/`pull_request` scoped to `branches: [main]` to unscoped `pull_request:`, `push:`, and `workflow_dispatch:` - add `name: 🚦 Pull request checks` to the `checks`, `build`, and `e2e` jobs
- new `.github/workflows/sanity-check.yml` runs `bun run system-check` on `push: branches: [main]` only - sets `concurrency.cancel-in-progress: false`, unlike `pull-request-checks.yml`'s unconditional `cancel-in-progress: true`, so a rapid second push to `main` can no longer cancel an in-flight check run and leave a merged commit unverified
✅ Deploy Preview for kasane-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- top-level `name:` becomes `🧪 Pull request checks` (was `🧪 Pull Request Checks`)
- remove `name: 🚦 Pull request checks` from the `checks`, `build`, and `e2e` jobs - jobs go back to having no `name:` field, as before the rename
codebend3r
changed the title
- drop `push:` and `workflow_dispatch:` from `on:`, leaving `pull_request:` - keeps pull request checks off `main`, where `sanity-check.yml` covers verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keepaliveworkflow to💓 Keepalivein.github/workflows/keepalive.yml.github/workflows/ci.ymlto.github/workflows/pull-request-checks.ymland retitleCIto🧪 Pull request checkson:to justpull_request:— drops thepush:trigger so pull request checks never run onmain, and unscopespull_requestfrombranches: [main]checks,build, ande2ejobs are otherwise unchanged and still carry no job-levelname:.github/workflows/sanity-check.yml(✅ Sanity check) runningbun run system-checkonpush: branches: [main]only, so verification ofmainmoves hereconcurrency.cancel-in-progress: false, unlikepull-request-checks.yml's unconditionalcancel-in-progress: true, closing the gap where a rapid second push tomaincould cancel the only verification run of a merged commit