fix(update): report download progress and reclaim abandoned temporaries - #55
Merged
Merged
Conversation
This was referenced Sep 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nightcrow updateprinted nothing while streaming a ~14 MiB release binary, so a slow download is indistinguishable from a no-op — users interrupt it, which in turn leaves.nightcrow-download-*temporaries thatsweepnever reclaimed (it only matched*.nightcrow-old.N).What
updatereports the download: a start line with the asset size, a throttled in-place percentage on a terminal, one line per 10% on a plain log, and averifyingline before the checksum check.sweepalso removes.nightcrow-download-*leftovers, but only those older than an hour, so it cannot unlink the temporary of an update that is still running.docs/getting-started.md.Verification
cargo fmt --all --check,cargo clippy --locked --workspace --all-targets --all-features -- -D warnings, andcargo test --locked --bin nightcroware green at each commit (the intermediate commit was verified in a separate worktree).