Repository navigation
ci: attach required checks to Dependabot PRs; peer pi-* >=0.87.1 - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #55, #53 and #54. This is the same change as code-yeongyu/pi-comment-checker#21, Opus-reviewed there; the review fixes are included: the dispatch fallback is kept when
gh run listfails, plus an accurate header comment.1. Required checks on Dependabot PRs
On pi-comment-checker #19 (this repo has the same workflow and approval policy), the refresh workflow's
bun.lockcommit (pushed withGITHUB_TOKEN) did create apull_requestCI run, 37900166347. Becausegithub-actions[bot]counts as a first-time contributor under this repo's approval policy (first_time_contributors), that run waited for approval, never ran any jobs, and ended as a failure after about 15 minutes. Theworkflow_dispatchrun reported the required check names on the commit, but dispatched check suites have no PR association (pull_requests: []), so the PR rollup showed only GitGuardian and the merge needed--admin.dependabot-bun-lock.ymlnow does this after its push:pull_requestrun ofci.yml, then approves it (POST /actions/runs/{id}/approve, using the job's existingactions: write), so the required checks run on the PR itself;ci.ymlas before. The result is never worse than today.Unverified: whether the approve endpoint accepts a same-repo run, since GitHub documents it for fork PRs from first-time contributors. This can't be exercised outside a real Dependabot push. The next npm Dependabot PR will show either
approved pull_request run <id>or the fallback warning in the refresh job's log.2. Peer range
peerDependencieson@earendil-works/pi-ai,pi-coding-agentandpi-tuichange from*to>=0.87.1. Development now tests against pi 1.0.4, so I checked the old floor. With every@earendil-workspackage pinned to 0.87.1 (installed versions verified innode_modules),bun run typecheckreports 0 errors andbun run testpasses 76/76. That covers typecheck and the unit tests, not a livepi -eload. Below 0.87.1 is untested, which is why the range no longer claims it.bun.lockandpackage-lock.jsonare regenerated to match.Checks
bun run checkpass.actionlintis clean on all workflows.