feat(currency-info): revamped new-UI token info layout - #583
Closed
bmc08gt wants to merge 1 commit into
Closed
Conversation
bmc08gt
force-pushed
the
feat-currency-info-v2
branch
from
August 15, 2026 01:54
d7259f0 to
eb529b7
Compare
Behind BetaFlags.newUI, replace the currency info screen with the new layout:
a hero bill card, inline Give / Convert / Withdraw tiles (a single Get when the
token is not held), a per-token Recent preview, the reused market-cap chart,
the About block, and a created-at footer. The legacy layout is untouched.
- Actions: Give -> give; Convert / Get -> the pushed buy flow; Withdraw ->
withdrawCurrency(mint) (pre-selected).
- USDF: Convert + Withdraw only, no market-cap chart, no created date, not
shareable, and the title uses the mint name ("Dollars").
- Title bar: a leading Liquid Glass pill (icon, name, market cap) revealed only
once the hero card title scrolls under the bar; the bar background is hidden
and the top scroll edge softened so content scrolls beneath it.
- Reuse: CurrencyInfoMarketCapSection as-is; About extracted to
CurrencyInfoAboutSection (keeps expand/collapse). Per-token Recent loads via
the view model, keeping DB access out of the view.
- Spacing across this screen and the wallet snaps to the 4pt grid.
Builds on the pushable buy flow (.buyCurrency).
bmc08gt
force-pushed
the
feat-currency-info-v2
branch
from
August 15, 2026 14:11
5319c4f to
257ae64
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamps the token/currency info page for the new UI (
BetaFlags.newUI), per the Figma frames9121-14267,9137-9119,9137-9343and the notes below them. The legacy layout is untouched for the old UI.Layout (top → bottom)
TokenCardView. Balance + appreciation pill when held; identity only when not.CurrencyInfoMarketCapSectionas-is (value + monthly delta live inside the interactive chart).CurrencyInfoAboutSection(keeps ExpandableText expand/collapse) + social links.Title bar
onScrollGeometryChange.glassEffect(.regular, in: .capsule)) instead of the toolbar's platter: the system platter hugs its content and swallows most of the trailing inset the spec calls for. Measured against the spec — height 36pt (spec ~37), width 112pt (~107), trailing gap 21pt..primary/.secondaryso the glass applies the system's vibrancy and stays legible over a bright bill card scrolling beneath..soft, so content fades under the bar instead of meeting a hard line. The bar background is deliberately left in place — hiding it removes the surface that effect renders into.Behaviour
.give(mint); Convert / Get → the pushed buy flow (.buyCurrency, feat(buy): allow the buy flow to be pushed onto a host stack #584); Withdraw →.withdrawCurrency(mint), pre-selected.loadRecentActivities), keeping DB access out of the view.Fixes found while iterating on device
padding(.horizontal, -20), making that row wider than the viewport and letting the page pan sideways. Insets are now applied per section; the chart still bleeds edge to edge.Testing
Built and run on the iPhone 17 simulator and on device (iOS 27). Driven with Maestro:
Follow-ups (deliberately not here)
matchedGeometryEffectarchitecture rather than a nav push).WalletActivityRow(single avatar) vs the frames' dual-token swap rows.6/2) is the one remaining off-grid value; left alone as it was ported to match the Figma card spec.