refactor(core-ui): extract shared UI into :apps:flipcash:core-ui - #1233
Merged
Conversation
Move the shared Compose UI out of :apps:flipcash:core into a new :apps:flipcash:core-ui module so it can depend on :shared:featureflags (core cannot without a dependency cycle). - Move all composables under core/ui (+ internal/ui/previews) to core-ui, keeping the com.flipcash.app.core.ui package so call-site imports are unchanged. - Keep SteppedFlowRoute (a route type, not UI) in core, relocated to the core.navigation package. - Wire core-ui into feature modules via the feature convention plugin, excluding core, core-ui and featureflags to avoid a cycle; add explicit deps for the two non-feature-plugin consumers (app, chat-ui).
github-actions
Bot
added
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts the shared Compose UI out of
:apps:flipcash:coreinto a new:apps:flipcash:core-uimodule.Why
core-uican depend on:apps:flipcash:shared:featureflags, whichcorecannot without a dependency cycle. This unblocks shared UI (e.g. the appreciation badge) from reading feature flags / other higher-level shared state, and gives the shared composables a dedicated home instead of living in the basecoremodule.Changes
:apps:flipcash:core-uimodule — depends onfeatureflags,material3, and thehazebundle (the non-transitive libs the moved composables use).core/ui/**(plusinternal/ui/previews) intocore-ui, keeping thecom.flipcash.app.core.uipackage so call-site imports are unchanged.SteppedFlowRoutestays incore— it is a route type, not UI — relocated to thecom.flipcash.app.core.navigationpackage (updated its two references).core-uiis added to feature modules via the feature convention plugin, excludingcore,core-ui, andfeatureflagsto avoid a dependency cycle (core-ui→core→featureflags). The two non-feature-plugin consumers (app,chat-ui) get an explicit dependency.FlowProgressTestintocore-ui.Almost entirely renames (42 files, +38/−2). No behavioural change:
CurrencyAppreciationLabel(incl. the existingAppreciationStyle) moves across unchanged.Verification
./gradlew :apps:flipcash:app:compileDebugKotlin— SUCCESS (no cycles):apps:flipcash:core-ui:testDebugUnitTest— passes:apps:flipcash:core:compileDebugUnitTestKotlin— compiles