feat(wallet): v2 card-stack collapse + appreciation pill - #1231
Merged
Conversation
- TokenCardStack: set collapsedReveal default to 0 dp so back cards hide completely behind the front card when fully collapsed (no slivers); fanned reveal stays at 64 dp. - CurrencyAppreciationLabel: add AppreciationStyle enum (Classic/Pill). Classic (default) keeps the existing sentiment-tinted fill so all current call sites are unchanged. Pill renders a neutral bordered box with secondary text colour for use in the v2 wallet header. - BalanceHeader: add topPadding/bottomPadding params (default: grid.x9 for both, preserving v1 behaviour) and appreciationStyle param. - WalletScreenContent: remove the leading x15 spacer; pass topPadding=96 dp, bottomPadding=44 dp, and AppreciationStyle.Pill to BalanceHeader to match Figma node 8966:1578. Parity with iOS PR #574.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android parity with iOS PR #574 ("feat(wallet): v2 card-stack collapse + appreciation pill").
Card-stack collapse to zero:
TokenCardStack.collapsedRevealdefault changed from 12 dp to 0 dp. Back cards now collapse completely behind the front card with no visible slivers. The fanned reveal (64 dp) and scroll-driven collapse mechanism are unchanged.Appreciation pill (v2): Added
AppreciationStyleenum (Classic/Pill) toCurrencyAppreciationLabel.Classic(default) keeps the existing sentiment-tinted fill — all current call sites (TokenBalance,BalanceScreenContent) are unchanged.Pillrenders a neutral bordered box (1 dpWhite20border,extraSmallcorner radius) with secondary text colour and "from appreciation" / "from depreciation" labels matching the iOS pill. New string resourceslabel_fromAppreciationandlabel_fromDepreciationadded tostrings.xml.WalletScreen header spacing (v2):
BalanceHeadergainstopPadding/bottomPadding/appreciationStyleparams (all defaulting to current v1 values).WalletScreenContentremoves the precedingx15spacer and passestopPadding=96 dp,bottomPadding=44 dp,AppreciationStyle.Pill— matching Figma node 8966:1578.Test plan
./gradlew :apps:flipcash:core:compileDebugKotlin :apps:flipcash:features:balance:compileDebugKotlin— verified green.