feat(profile): add helper sublabel below display name input field - #1229
Merged
Conversation
Add an optional sublabel param to DisplayTextInput so the helper text is laid out inside the component's column, directly below the field. Apply the scaffold content padding to a wrapper column rather than the field so the sublabel hugs the entered text instead of being pushed far below it.
bmc08gt
force-pushed
the
feat/display-name-sublabel
branch
from
August 13, 2026 15:44
c2c14d4 to
379f794
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a helper sublabel "This is how you'll appear to others" directly below the name input on the display-name entry screen (
NameEntryScreen), per the new Figma design (node 8966-1323).How
DisplayTextInputgains an optionalsublabel: String? = nullparam (plussublabelStyle, defaulting totextSmall/textSecondary). The component now lays out the field and sublabel in aColumn, so the helper text is rendered inside the component, directly beneath the field. This avoids the overlap that occurs when a sublabel is added as a sibling inCodeScaffold's content slot (which stacks its children).NameEntryScreenpassessublabel = stringResource(R.string.subtitle_profileNameSelection)and applies the scaffold's content padding to a wrapperColumnrather than the field itself — otherwise the padding inflates the field's box and pushes the sublabel far below the entered text instead of hugging it.strings.xmladdssubtitle_profileNameSelection.Testing
:apps:flipcash:app:installDebugbuilds clean and runs on a Pixel_10 emulator (Android 17).The iOS counterpart is code-payments/code-ios-app#571.