fix(v2): host the tab bar as a bottom overlay, not a scaffold bottomBar - #1227
Merged
Conversation
As a Material2 Scaffold bottomBar the tab bar couldn't win either way: hiding it for a modal collapsed the scaffold's bottom slot and re-laid-out the content beneath (re-fanning the wallet's collapsing card stack), while keeping it visible drew it on top of the modal (bottomBar is painted over content). Move it to a bottom overlay over full-height nav content, as its own docs always described. The body no longer resizes when the bar hides, so hiding it for a BottomBar modal (restored) or a bill is free — no jump — and the modal renders over the now-absent bar. LocalTabBarPadding is provided from the bar's tallest measured height, latched and gated to tab homes, so a modal-driven hide doesn't shrink the inset. Content now also scrolls edge-to-edge under the frosted bar, which is what the Haze blur wants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As a Material2
ScaffoldbottomBar, the v2 tab bar couldn't be correct either way:Fix
Host
AppNavigationBaras a bottom overlay over full-height nav content — which is exactly what its own doc always described ("a full-size, touch-transparent overlay pinned to the bottom"):LocalTabBarPaddingis provided from the bar's tallest measured height, latched and gated to tab homes, so a modal-driven hide doesn't shrink the inset.Test Plan