refactor(ui): AppBarWithTitle custom title + append close after end actions - #1223
Merged
Conversation
…ctions Add an optional titleContent slot so callers can render a composable title (e.g. a token icon + name) instead of a plain string, and widen endContent to a RowScope receiver. When the leading control resolves to a Close, append it *after* the caller's end actions (furthest toward the screen edge, the conventional dismiss spot) rather than replacing them — TopAppBarBase already lays these out in an EndActionSlotHolder, so a back arrow never shares the leading slot with a close. TokenInfoScreen adopts the new slots: titleContent for the token icon/name and an explicit onBackIconClicked, dropping its manual trailing Close.
github-actions
Bot
added
area: ui
github-actions
Bot
added
the
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleContentslot toAppBarWithTitleso callers can render a composable title (e.g. a token icon + name) instead of only a plain string, and widenendContentto aRowScopereceiver.TopAppBarBasealready lays these out in anEndActionSlotHolder, so a back arrow never shares the leading slot with a close.TokenInfoScreenadopts the new slots:titleContentfor the token icon/name + an explicitonBackIconClicked, dropping its manual trailing Close.Test Plan
:apps:flipcash:app:assembleDebugcompiles (50+AppBarWithTitlecallers — signature change is source-compatible).