Publish stage clears its download folders so a leftover tarball cannot be read - #686
Draft
mcollinscodat wants to merge 1 commit into
Draft
Publish stage clears its download folders so a leftover tarball cannot be read#686mcollinscodat wants to merge 1 commit into
mcollinscodat wants to merge 1 commit into
Conversation
…wnload folders so a leftover tarball can't be read - .azuredevops/npm-publish.yml - remove pack-out and release-facts before the artifact downloads, fail unless pack-out holds exactly one .tgz, and publish that named file instead of ./*.tgz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Azure DevOps pipeline that publishes this repo's npm packages reads the packed tarball out of a folder it never empties, so a run that lands on an agent which has already served an earlier release finds that release's tarball still on disk and picks up both filenames as one. Platform 7.0.0 failed to publish on 27 August this way: lending's tarball from a run that had finished moments earlier was still there,
tarwas handed both names as a single filename, and nothing reached npm. A straight re-run hit the same wall against a different leftover, so the release stayed stuck.Changes
This file is generated, so the change was made at its source and delivered here unchanged.
Verification
The structural tests for this pipeline pass at the source, and the new guard was exercised in bash with zero, one and two tarballs in the folder. All tests passing.