Repository navigation
test(lass): add LASS unit tests to ctest - #200
Merged
Merged
Conversation
Adds a small LASS test executable (registered as LASS.UnitTests, only built when BUILD_TESTING is on) covering common and crash-prone cases: MultiPan/Reverb copy ownership, Sound detune validation and invalid partial counts, Spatializer output, Envelope interpolation, MarkovModel sampling/invalid states, and Pan with one or three channels. Several of these are regression tests for the MarkovModel, Sound and Pan fixes from #191. Since #193, CI runs ctest on Linux, Windows and macOS, so these now run on every PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each test now runs through a small runTest() wrapper that: - prefixes every failure message with the name of the test it came from, - treats an unexpected exception as a failure of that test only, so the remaining tests still run instead of the whole program stopping, - prints "RUN <name>" before each test, so if one crashes outright the last RUN line in the CI log names it, - ends with a list of exactly which tests failed. This keeps LASS.UnitTests a single ctest entry while making a red CI check point straight at the specific broken test(s). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first non-UI test suite to CI: a small LASS unit test executable, registered with ctest as
LASS.UnitTests. It's only built whenBUILD_TESTINGis on, so normal builds and app startup are unaffected.Since #193, CI runs
cteston Linux, Windows and macOS, so these run on every PR automatically with no workflow changes.What it covers (10 small checks, aimed at common and crash-prone mistakes):
The regression tests were each confirmed to fail against the pre-fix code and to pass with the fixes.
🤖 Generated with Claude Code