feat: Add icon support to Badge - #4973
Draft
jperals wants to merge 1 commit into
Draft
Conversation
Add the ability to render an icon inside a Badge, modeled on the Button component's icon feature. - Add iconName, iconUrl, iconSvg, iconAlt, and iconAlign props to BadgeProps. The icon uses size="inherit" and a flex container so it stays vertically centered with the label text. - Extract shared iconName/iconUrl/iconAlt props into a new BaseIconProps interface consumed by both Badge and Button. iconSvg is intentionally left out, since its documentation is component-specific. - Add stable .content and .icon test-util selectors in a dedicated badge/test-classes/styles.scss, decoupled from structural styles. - Add findIcon and findContent methods to the Badge test-utils wrapper, using findContent to match the library-wide convention. - Add a badge icon permutations dev page. - Update documenter and test-utils selectors snapshots.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4973 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 959 959
Lines 31345 31362 +17
Branches 11579 11589 +10
=======================================
+ Hits 30614 30631 +17
Misses 724 724
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to render an icon inside a Badge, modeled on the Button component's icon feature.
iconName,iconUrl,iconSvg,iconAlt, andiconAlignprops to BadgeProps. The icon usessize="inherit"and a flex container so it stays vertically centered with the label text.BaseIconPropsinterface consumed by both Badge and Button.iconSvgis intentionally left out, since its documentation is component-specific..contentand.icontest-util selectors in a dedicatedbadge/test-classes/styles.scss, decoupled from structural styles.findIconandfindContentmethods to the Badge test-utils wrapper, usingfindContentto match the library-wide convention.Description
Related links, issue #, if available: n/a
How has this been tested?
Visual regression tests will be added in follow-up PR.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.