feat: allow skipping secondary themes in themed builds - #4971
Draft
Harsh-Anand-Singh wants to merge 1 commit into
Draft
feat: allow skipping secondary themes in themed builds#4971Harsh-Anand-Singh wants to merge 1 commit into
Harsh-Anand-Singh wants to merge 1 commit into
Conversation
Harsh-Anand-Singh
marked this pull request as ready for review
September 3, 2026 15:02
Harsh-Anand-Singh
requested review from
pan-kot and
ywyyu17
and removed request for
a team and
ywyyu17
September 3, 2026 15:02
Harsh-Anand-Singh
force-pushed
the
feat/skip-secondary-themes
branch
from
September 3, 2026 15:04
cfc8815 to
5f0080f
Compare
Harsh-Anand-Singh
changed the base branch from
feat/website-theme-namespace
to
main
September 3, 2026 15:05
Harsh-Anand-Singh
marked this pull request as draft
September 3, 2026 15:05
Harsh-Anand-Singh
marked this pull request as ready for review
September 3, 2026 15:06
Harsh-Anand-Singh
changed the title
Harsh-Anand-Singh
marked this pull request as draft
September 3, 2026 15:51
Harsh-Anand-Singh
marked this pull request as ready for review
September 3, 2026 15:53
pan-kot
reviewed
Sep 4, 2026
| theme, | ||
| outputDir, | ||
| baseThemeId, | ||
| includeSecondaryThemes = true, |
Member
There was a problem hiding this comment.
We should not make public API changes like that without good justification.
pan-kot
requested changes
Sep 4, 2026
Harsh-Anand-Singh
marked this pull request as draft
September 4, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeSecondaryThemesparameter tosrc-themeable/buildThemedComponentstrue, so existing consumers are unchangedfalse, the wrapper forwards the preset withsecondary: []