Skip to content

chore: Implement dropdown async - #4968

Draft
NathanZlion wants to merge 3 commits into
mainfrom
dev-v3-natidere-button-dropdown-async-filtering
Draft

chore: Implement dropdown async#4968
NathanZlion wants to merge 3 commits into
mainfrom
dev-v3-natidere-button-dropdown-async-filtering

Conversation

@NathanZlion

Copy link
Copy Markdown
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.75281% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.66%. Comparing base (fe20f7a) to head (ca88f2f).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
.../category-elements/expandable-category-element.tsx 94.28% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4968    +/-   ##
========================================
  Coverage   97.66%   97.66%            
========================================
  Files         958      960     +2     
  Lines       31317    31424   +107     
  Branches    11565    11635    +70     
========================================
+ Hits        30585    30691   +106     
+ Misses        725      687    -38     
- Partials        7       46    +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Render DropdownStatus directly (no DropdownFooter border) when
  items are empty and status is sticky (loading/error state)
- Apply fix to both main dropdown (internal.tsx) and expandable
  group sub-dropdown (expandable-category-element.tsx)
- Remove dead code: fireGroupLoadItems was exported but never called
- Add use-load-items.test.tsx covering handleLoadMore and
  handleRecoveryClick branches
- Improve test coverage for DropdownStatus direct-render path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant