Skip to content

feat: wire motion trigger into components - #4941

Draft
mxschll wants to merge 2 commits into
mainfrom
dev-v3-schomax-motion-regions
Draft

feat: wire motion trigger into components#4941
mxschll wants to merge 2 commits into
mainfrom
dev-v3-schomax-motion-regions

Conversation

@mxschll

@mxschll mxschll commented Aug 27, 2026

Copy link
Copy Markdown
Member

Adds motion trigger and target attributes to components.

Context: b9VcPdMJ5zRn / NVoiJ1X1df9a.

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxschll mxschll changed the title feat(motion): wire hover/focus motion trigger+target attributes into … feat: wire hover/focus motion trigger+target attributes into components Aug 27, 2026
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (0c1c9fd) to head (0e001a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4941   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         959      959           
  Lines       31345    31354    +9     
  Branches    11579    11588    +9     
=======================================
+ Hits        30614    30623    +9     
+ Misses        724      685   -39     
- Partials        7       46   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll changed the title feat: wire hover/focus motion trigger+target attributes into components feat: wire hover/focus motion trigger into components Aug 27, 2026
@mxschll
mxschll force-pushed the dev-v3-schomax-motion-regions branch from 01b436b to 0d0aeef Compare September 4, 2026 14:46
@mxschll mxschll changed the title feat: wire hover/focus motion trigger into components feat: wire motion trigger into components Sep 4, 2026
@mxschll
mxschll requested a review from pan-kot September 4, 2026 14:58
ref={ref}
startIcon={startIcon}
endIcon={<InternalIcon name="angle-right" />}
endIcon={<InternalIcon name="angle-right" nativeAttributes={{ 'data-awsui-motion-target': '' }} />}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to play animation for the "angle-right" and not custom provided icons, as hovering + focus is coupled with the angle icon action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant