chore(greenhouse): remove legacy teams and secrets code - #1898
chore(greenhouse): remove legacy teams and secrets code#1898guoda-puidokaite wants to merge 1 commit into
Conversation
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
🦋 Changeset detectedLatest commit: 6c3a816 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
guoda-puidokaite
changed the title
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes the legacy Teams and Secrets org-admin plugin implementations and prunes related API schema/types so the Greenhouse org-admin UI no longer exposes or compiles those features.
Changes:
- Removed Teams and Secrets plugin code (components, hooks, stores, fixtures, tests, and styles).
- Removed Teams/Secrets entries from org-admin navigation and plugin routing.
- Pruned related OpenAPI/CRD type definitions and removed
lodashdependencies no longer needed.
Reviewed changes
Copilot reviewed 46 out of 51 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/greenhouse/src/components/core-apps/org-admin/components/SideNav.tsx | Removes Teams/Secrets from the visible org-admin navigation. |
| apps/greenhouse/src/components/core-apps/org-admin/AppContent.tsx | Removes lazy imports and routing for Teams/Secrets plugins. |
| apps/greenhouse/src/components/core-apps/org-admin/types/schema.d.ts | Removes Team* path/component types from org-admin type schema. |
| apps/greenhouse/src/components/admin/types/schema.d.ts | Removes Team/TeamRole/TeamRoleBinding types from admin schema. |
| apps/greenhouse/package.json | Removes lodash and @types/lodash dependencies as part of legacy code removal. |
| .changeset/forty-grapes-jog.md | Adds a patch changeset documenting removal of legacy teams/secrets code. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import { useActivePlugin } from "./StoreProvider" | ||
| import { lazy, Suspense } from "react" | ||
| const Clusters = lazy(() => import("./components/clusters/App")) | ||
| const Secrets = lazy(() => import("./components/secrets/App")) | ||
| const Plugins = lazy(() => import("./components/plugins/App")) | ||
| const Teams = lazy(() => import("./components/teams/App")) | ||
|
|
||
| // import Plugin from "./Plugin" | ||
|
|
| case "clusters": | ||
| ActivePlugin = Clusters | ||
| break | ||
| case "secrets": | ||
| ActivePlugin = Secrets | ||
| break | ||
| case "plugins": | ||
| ActivePlugin = Plugins | ||
| break | ||
| case "teams": | ||
| ActivePlugin = Teams | ||
| break | ||
| default: | ||
| ActivePlugin = Clusters | ||
| } |
taymoor89
left a comment
taymoor89
left a comment
There was a problem hiding this comment.
Nice cleanup!
I was imagining that we'd remove entire /src/core-apps section which was old greenhouse admin area.
| import { lazy, Suspense } from "react" | ||
| const Clusters = lazy(() => import("./components/clusters/App")) | ||
| const Secrets = lazy(() => import("./components/secrets/App")) | ||
| const Plugins = lazy(() => import("./components/plugins/App")) |
There was a problem hiding this comment.
I'm thinking, shouldn't we remove that too?
Summary
Removed legacy code for teams and secrets admin apps, cleaning up dependencies