Repository navigation
ci: the app's controls are Kumo's, and a new one written by hand fails - #94
Conversation
`pnpm static controls` reads every .tsx file in app/, a tag whole across lines, and refuses: - a <select>, <textarea>, <input> or <button> written by hand, unless it is kept on purpose with its reason (ON_PURPOSE) or is a debt of the day the check came in (TO_MOVE: 62 places in 30 files); - a height, size, corner or type size written by hand on a Kumo control (SIZED_BY_HAND: six pill buttons when it came in). A debt only goes down: a count above it is refused, and one below it until the number is lowered. #82 and #83 pay it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
The UI skill's rule 6 names Kumo's component for each kind of control, where its documentation is, and where a wrapper lives when Kumo's cannot do the job. Its "before you finish" list asks for every changed screen to be opened at desktop and phone width in both themes, compared with the screen beside it, and shown in the pull request. The pull-request template asks for the pictures. The status document records the check and its debt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
Audit at ddece76: four additions to the check, then passRead: the check, its tests, the skill's rule 6, the template and the status row. Nothing was run. What holds
To addI tried to write a control that looks wrong and passes. These four get through, and #82 and #83 are exactly where someone will reach for them: 1. Padding, an arbitrary size and the important mark. 2. 3. A control made of a role. 4. Kumo's own parts, and the project's wrappers. A tag such as Each with a test that fails without it. To write down as what the check does not prove
These are held by the audit opening the screen, which is the last item of #84 and is mine from here on: I open every changed screen on a local instance before a pull request under The checks were still running when I read this. |
The audit of #94 asked for four more refusals, each with a test: - padding, an arbitrary text-[…], leading- and the important mark on a Kumo control; - a style attribute on one; - a plain element with the role of a control (button, checkbox, radio, switch, combobox, listbox, textbox, slider), with the one place that has one today, the address list's listbox, held as a debt; - Kumo's dotted parts and the wrappers of app/components/controls/. The file's header and the status document say what the check does not prove: createElement or a tag in a variable, a Kumo control under another name, and a class from a variable or after a ${…}. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
|
Answer to the audit at ddece76. One new commit, 0811b03.
What it does not prove is now in the file's header and in the status row:
Debt. No new places came up under 1, 2 or 4: the six pill buttons are still all there is. Under 3, the one listbox above. No screen was changed. Tests. |
|
audit: pass, once the required checks are green Read at 0811b03, the one new commit. The four additions are in, each with its test:
What the check does not prove is in its header and the status row, and is held by the audit opening the screen. Merge with a merge commit, and name both runs. This closes the first three parts of #84; the fourth, the audit opening every changed screen, starts with the next pull request under |
Issue #84: the check, the skill's rule, the template. It comes before #82 and #83, which move the controls.
The check.
pnpm static controls(scripts/checks/controls.ts, inpnpm check). It reads every.tsxfile inapp/, each tag whole, across lines, braces and quotes.<select>,<textarea>,<input>and<button>, except:ON_PURPOSE, one line per native control that stays, with its reason. It is empty now; The app builds its form controls by hand beside Kumo's #82 decides each button;TO_MOVE: what was written by hand when the check came in (main at b200fd7), counted per element per file. That is 62 places in 30 files, the same as the table on The app builds its form controls by hand beside Kumo's #82.h-,min-h-,max-h-), a size (size-), a corner (rounded) or a type size (text-xs…text-9xl) onButton,Input,Selector another Kumo control, under a breakpoint or incn()too. Width and margins are the screen's layout and are left alone.rounded-full, inComposePanel,EmailPanelandSendLater). Kumo'sshapegives round corners to icon buttons only, so these six are a debt inSIZED_BY_HANDfor The app builds its form controls by hand beside Kumo's #82 and The filter dialog and the automatic reply: controls of different sizes, and edges that do not line up #83 to decide.Proof.
test/unit/controls.test.ts, 21 tests:cn()), and layout classes passed.With the check emptied, 18 of the 21 fail. The repository passes with the debt as listed.
The skill (
podbay-ui, rule 6):Select/Combobox,Radio,Checkbox,Switch,Input,InputArea,SensitiveInput,TagInput,DatePicker,Button,FieldwithLabel;node_modules/@cloudflare/kumo/ai/component-registry.md. That is where I read the components and their sizes:smis 26 px,base36 px;sizeprop, and one form uses one size;app/components/controls/.The "before you finish" list asks for:
The template. A change under
app/carries those pictures, or says why there is nothing to see.Screens. This pull request changes no screen: no file under
app/is touched. So there are no pictures.Not in this pull request. The last item of #84, the auditor opening a changed screen in a browser before a pass, is the auditor's own practice.
Locally, on
mainat b200fd7:pnpm checkpassed, with 22 static checks and 974 unit tests.🤖 Generated with Claude Code