migrate crashes at its audit step with HANDLER_CRASHED when no server observations exist #183

Activity

1. shipmill-romamo

   added

   bugSomething isn't workingSomething isn't working

   on Oct 30, 2026
2. shipmill-romamo commented on Oct 30, 2026

   

   shipmill-romamoBot

   on Oct 30, 2026 – with shipmill-romamo

   ContributorAuthor

   More actions

   Triage: implement. A bug fix (quality bar). Reproduced from the code on main (70a167f): the audit step's runner, _verify_audit in sdk/src/cloudfall/migrate.py, calls load_observations, which raises ConfigValidationError (observation_directory_missing) when the observed directory doesn't exist. The step loop in execute_migration only catches MigrateError and LifecycleError, so the error escapes as HANDLER_CRASHED. The routes step (_verify_routes) calls load_observations the same way and crashes the same way.

   Plan: both steps stop with a typed error instead. Each raises MigrateError with a new code, migrate_observations_missing, whose detail names the missing directory and the command that records observations (cloudfall observe). The run saves its plan and reports the failing step as any other step error does, so a rerun after observe resumes at that step. An observed directory that exists but holds no snapshot for a declared server is left as it is: the audit reports it as drift (migrate_audit_drift), already a typed error. A regression test runs migrate --yes through the step with no observed directory and checks the code, and that the run isn't HANDLER_CRASHED.
3. shipmill-romamo commented on Oct 30, 2026

   

   shipmill-romamoBot

   on Oct 30, 2026 – with shipmill-romamo

   ContributorAuthor

   More actions

   PR: #184. audit and verify-routes now check for the observed directory first and fail with migrate_observations_missing, naming the directory and cloudfall observe; the plan is saved, so a rerun after observe resumes at that step. The CLI reports it as ENGINE_STEP_FAILED (exit 87), as it does every other migrate step error, rather than the PRECONDITION this issue suggested. A malformed snapshot and a server without one behave as before.
4. shipmill-romamo

   added a commit that references this issue on Oct 30, 2026

   Name missing observations at migrate's verify steps instead of crashing

   ...

   This issue will close once commit 8c99771 is merged into the 'main' branch.

   8c99771
5. shipmill-romamo

   closed this as completedin #184on Oct 30, 2026
6. shipmill-romamo commented on Oct 31, 2026

   

   shipmill-romamoBot

   on Oct 31, 2026 – with shipmill-romamo

   ContributorAuthor

   More actions

   Released in v0.8.0rc13 (pre-release).
   A plain install gets it with the next stable release.
   If you filed this: react 👍 on this comment once it works for you, or reply if it doesn't.