Skip to content

Run the command health check in restart, rollback and health (S-009-10) #166

Closed

Description

@shipmill-romamo

Builds part of spec S-009, docs/specs/009-command-health-check.md (feature issue #152): the acceptance criteria below. Each needs a test that names its id (test_s009_<k>_..., or a proves: S-009-10 comment line).

This is the command check in restart, rollback and health.

  • S-009-10: restart, rollback and health of a component with a command check run the same check; health reports unhealthy when it exits non-zero, and none of them writes a receipt

Depends on #164

Activity

  1. shipmill-romamo commented on Oct 30, 2026

    @shipmill-romamo
    ContributorAuthor

    Triage: implement. Serves: G-3. A build issue of spec S-009 (docs/specs/009-command-health-check.md, approved in #153), sub-issue of #152. The criteria above are the scope; each gets a test naming its id. It starts once every issue on its Depends on line has closed.

  2. shipmill-romamo commented on Oct 30, 2026

    @shipmill-romamo
    ContributorAuthor

    Unblocked: #164 closed. Dispatched as triaged above. This is S-009's last open build issue, so its PR also sets the spec to status: built with a Verification line per criterion.

  3. shipmill-romamo commented on Oct 30, 2026

    @shipmill-romamo
    ContributorAuthor

    PR: #185. restart, rollback and health now end on the same command check deploy runs (its tasks, reused), health reports unhealthy when it exits non-zero or times out, and none of the three writes a receipt. Spec S-009 is set to status: built, and the #161 and #164 changelog fragments no longer say these commands refuse a command check.

    Trade-offs: health of a component with a command check now needs the SSH account to become root (starting the check's unit needs it), as restart and rollback already do; a failed check after restart restores nothing, as the spec says for rollback and as an http check does today. Not yet run on a live Debian host: the tests use a stand-in systemd-run.

  4. shipmill-romamo commented on Oct 31, 2026

    @shipmill-romamo
    ContributorAuthor

    Released in v0.8.0rc13 (pre-release).
    A plain install gets it with the next stable release.
    If you filed this: react 👍 on this comment once it works for you, or reply if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions