Skip to content

Check --schema values and add migrate --data-schema (S-007-12, S-007-13) #126

Closed

Description

@shipmill-romamo

Builds part of spec S-007, docs/specs/007-data-copy-schemas.md (feature issue #82): the acceptance criteria below. Each needs a test that names its id (test_s007_<k>_..., or a proves: S-007-12 comment line).

This is the --source-schema argument checks and migrate --data-schema. The flag is --source-schema (MCP source_schema), on the maintainer's answer on #134; migrate --data-schema keeps its name.

  • S-007-12: --source-schema 'Bad;Name', --source-schema app --source-schema app, or cloudfall migrate --data-schema crm=public without --data crm=<file> exits PRECONDITION and runs no playbook
  • S-007-13: cloudfall migrate --data crm=<file> --data-schema crm=public --yes copies only public into crm, as data copy --source-schema public does

Depends on #124

Activity

  1. shipmill-romamo commented on Oct 27, 2026

    @shipmill-romamo
    ContributorAuthor

    Triage: implement, for the next release candidate.

    The plan: build the criteria listed in the body, as docs/specs/007-data-copy-schemas.md (S-007, approved in #103) says, each with a test that names its id. A departure from a criterion goes back as a question, never a quiet change. Build issues start in order: this one starts once every issue on its Depends on lines has closed. I'll link the PR here.

  2. shipmill-romamo commented on Oct 30, 2026

    @shipmill-romamo
    ContributorAuthor

    Triage: implement, now that #124 merged in #134. The flag is --source-schema (MCP source_schema) on @romamo's answer on #134, and the body and spec 007 say so (#157). Since #134, schema names are a PostgresSchemaName (non-empty, at most 63 bytes, no control character or brace); S-007-12 tightens it to the spec's ^[a-z_][a-z0-9_]*$ and refuses a repeated name, which #134 still de-duplicates. S-007-6 also covers a gap #134 left: a named schema missing from the source is skipped while the receipt lists it. An implementer is on it.

  3. added a commit that references this issue on Oct 30, 2026
    745c129
  4. shipmill-romamo commented on Oct 30, 2026

    @shipmill-romamo
    ContributorAuthor

    Released in v0.8.0rc11 (pre-release).
    A plain install gets it with the next stable release.
    If you filed this: react 👍 on this comment once it works for you, or reply if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions