Repository navigation
Guard AWS credential steps against pull_request runs - #31
Merged
Merged
Conversation
Configure AWS credentials and Login to Amazon ECR were executed on every workflow run, including pull_request events, even though no image or chart is actually pushed on a PR. This unnecessarily minted an OIDC token and assumed the ECR IAM role on runners executing PR-controlled code. Gate both steps on the same condition that controls the actual publish: inputs.publish for artifacts.yaml, and a tag-push check for helm.yml. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Rommy-cbc
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: inputs.publishto theConfigure AWS credentialsandLogin to Amazon ECRsteps in both jobs ofartifacts.yamlso the OIDC token is not minted and the ECR IAM role is not assumed on PR runs (wherepublish: false).if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/deploy/charts/v')guard to the same two steps inhelm.ymlso credentials are only obtained when a chart is actually being pushed. This mirrors the existinghelm_push_enabledgate later in the workflow.Motivation
Both workflows trigger on
pull_requestand declareid-token: write, and the AWS credential + ECR login steps were unconditional. On PR events no image is pushed (docker/build-push-actionwrites to a local tar whenpublishis false) and no chart is pushed (helm push only runs on matching tags), so assuming the IAM role on a runner executing PR-controlled code offered no benefit and needlessly exposed short-lived STS credentials and an OIDC JWT.Test plan
deploy/charts/v*) still assumes the role and pushes the chart.mainpush publishes controller / refresher images via the normal path.🤖 Generated with Claude Code