Skip to content

build(deps): bump garm-provider-common for ppc64le, s390x and riscv64 - #39

Merged
gabriel-samfira merged 2 commits into
cloudbase:mainfrom
cbartz:feat/add-more-arches
Nov 16, 2026
Merged

gabriel-samfira merged 2 commits into
cloudbase:mainfrom
cbartz:feat/add-more-arches

Conversation

@cbartz

@cbartz cbartz commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Bumps garm-provider-common to main so the provider can create ppc64le, s390x and riscv64 runners.

The provider calls util.GetTools from NewMachineSpec. In v0.1.9 that function rejects every architecture except amd64, arm and arm64, so s390x instances fail with failed to get tools: unsupported OS arch: s390x, even when GARM (since cloudbase/garm#949) passes matching tools from a --tools-metadata-url. common's main removes that check (cloudbase/garm-provider-common#62).

common is not tagged yet, so this pins the pseudo-version v0.1.10-0.20261111212522-a63fbe8afd51, the same one garm-provider-lxd and garm-provider-incus use. It can move to the tag once one exists. Unlike those providers, this one has no architecture map of its own (the image decides the arch), so there is no code change.

  • build(deps): the common bump. go mod tidy also bumped a few indirect dependencies (httpsnoop, go-isatty, minio/sio, yaml/v4).
  • test(provider): NewMachineSpec picks the matching tools for amd64, arm64, arm, ppc64le and s390x. The ppc64le and s390x cases fail on v0.1.9 with the error above.

go test -race -mod=vendor -tags testing ./... passes. I did not run golangci-lint locally.

garm-provider-common v0.1.9 GetTools rejects any architecture other than
amd64, arm and arm64, so the provider fails to create s390x or ppc64le
instances even when GARM passes it matching runner tools. main drops that
check; it is not tagged yet, hence the pseudo-version.
@cbartz
cbartz marked this pull request as ready for review November 16, 2026 15:14
Copilot AI balanced review requested due to automatic review settings November 16, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Proxy values can execute shell commands as root, and the settings may not reach the runner or override existing package-manager proxies.

No open issues 🎉

What changed in this PR

Updates garm-provider-common so the OpenStack provider can select matching runner tools for ppc64le, s390x, and riscv64 without changing provider architecture logic.

Changes:

  • Pins the common library to a pseudo-version with expanded architecture mappings.
  • Adds NewMachineSpec tool-selection tests for five architectures.
  • Refreshes indirect dependencies and vendored code, including YAML processing and cloud-init proxy support.
File Description
vendor/​modules.txt Records updated dependency versions and packages.
vendor/​go.yaml.in/​yaml/​v4/​plugin/​limit/​plugin.go Adds configurable YAML safety limits.
vendor/​go.yaml.in/​yaml/​v4/​plugin.go Defines the safety-limit plugin interface.
vendor/​go.yaml.in/​yaml/​v4/​node.go Exposes node types through aliases.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​yamlprivate.go Removes relocated internal helpers.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​yamldatatest_loader.go Removes the old test-data loader.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​yaml.go Updates position handling and reorganizes types.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​structmeta.go Separates struct metadata extraction and caching.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​serializer.go Separates node serialization from representation.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​resolver.go Adds a dedicated tag-resolution stage.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​representer.go Converts Go values into node trees.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​README.md Updates internal documentation and test references.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​reader.go Adopts stage-specific input errors.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​options.go Adds safety checks and legacy-mode options.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​node.go Updates stream metadata and node conversion.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​loader.go Coordinates composition, resolution, and construction.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​errors.go Introduces stage-aware load and dump errors.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​dumper.go Coordinates the revised YAML output pipeline.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​desolver.go Removes inferable tags before serialization.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​composer.go Separates composition from tag resolution.
vendor/​go.yaml.in/​yaml/​v4/​internal/​libyaml/​api.go Removes relocated parser and emitter helpers.
vendor/​go.yaml.in/​yaml/​v4/​doc.go Corrects option examples in documentation.
vendor/​go.yaml.in/​yaml/​v4/​.typos.toml Allows new desolver terminology.
vendor/​go.yaml.in/​yaml/​v4/​.gitignore Refreshes upstream ignore patterns.
vendor/​github.com/​minio/​sio/​sio.go Adds 128-bit key support and updates cipher naming.
vendor/​github.com/​mattn/​go-isatty/​isatty_windows.go Accepts additional Windows terminal pipe suffixes.
vendor/​github.com/​felixge/​httpsnoop/​wrap_generated_lt_1.8.go Removes the legacy generated wrapper.
vendor/​github.com/​felixge/​httpsnoop/​wrap_generated_gteq_1.8.go Removes the previous generated wrapper.
vendor/​github.com/​felixge/​httpsnoop/​capture_metrics.go Tracks string writes and duration during panics.
vendor/​github.com/​cloudbase/​garm-provider-common/​util/​util.go Expands architecture mappings and tool selection.
vendor/​github.com/​cloudbase/​garm-provider-common/​params/​params.go Adds architecture constants and proxy configuration.
vendor/​github.com/​cloudbase/​garm-provider-common/​params/​github.go Adds a runner-download platform accessor.
vendor/​github.com/​cloudbase/​garm-provider-common/​errors/​errors.go Adds error types and corrects constructors.
vendor/​github.com/​cloudbase/​garm-provider-common/​cloudconfig/​util.go Adds proxy boot commands to cloud-init.
vendor/​github.com/​cloudbase/​garm-provider-common/​cloudconfig/​cloudconfig.go Switches YAML imports and supports boot commands.
provider/​spec_test.go Tests architecture-specific runner tool selection.
go.sum Updates dependency checksums.
go.mod Pins the common library and indirect upgrades.

Review effort: Balanced

@gabriel-samfira
gabriel-samfira merged commit 257c0bf into cloudbase:main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants