Skip to content

fix(provider): return valid instance statuses - #37

Merged
gabriel-samfira merged 1 commit into
cloudbase:mainfrom
rm-you:fix/provider-instance-status
Oct 19, 2026
Merged

gabriel-samfira merged 1 commit into
cloudbase:mainfrom
rm-you:fix/provider-instance-status

Conversation

@rm-you

@rm-you rm-you commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Nova servers in BUILD or DELETING are currently reported as pending_create or pending_delete, which GARM rejects in provider results. A single such server can fail validation of the entire ListInstances response and prevent pool or scale-set reconciliation. Other unmapped Nova states currently produce an empty status, which GARM also rejects.

Use typed constants for the existing ACTIVE, SHUTOFF, and ERROR mappings, and return InstanceStatusUnknown for all other states. Add table-driven conversion coverage and extend the existing HTTP list test with building and deleting servers alongside a running server.

Validation: the regression tests fail before the fix and pass afterward; the full vendored test suite passes with the race detector, as do repository lint, formatting, and dependency consistency checks.

rm-you added a commit to rm-you/garm-provider-openstack that referenced this pull request Oct 14, 2026

@gabriel-samfira gabriel-samfira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabriel-samfira
gabriel-samfira merged commit a33ad77 into cloudbase:main Oct 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants