fix(server-nestjs): surface post-creation repository sync failure - #2546
Open
shikanime wants to merge 1 commit into
Open
fix(server-nestjs): surface post-creation repository sync failure#2546shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I4e43b80955e4bc2697d31760828235af6a6a6964
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2519
Quel est le comportement actuel ?
À la création d'un dépôt avec URL externe, l'échec de la synchronisation post-création est avalé : un simple
logger.error, la requête répond 201 et l'utilisateur ne voit rien. Le legacy renvoyait un 422 (apps/server/src/resources/repository/business.ts).Quel est le nouveau comportement ?
L'échec de la sync post-création remonte à l'appelant en 422 (parité legacy), la ligne en base restant committée — la sync est rejouable via la route dédiée. Un événement sans destinataire (aucun plugin de sync activé) reste non bloquant mais est journalisé en avertissement.
Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Investigation détaillée dans les commentaires de #2519.