feat(environment): warn about linked deployments before environment deletion - #2517
Open
KepoParis wants to merge 1 commit into
Open
feat(environment): warn about linked deployments before environment deletion#2517KepoParis wants to merge 1 commit into
KepoParis wants to merge 1 commit into
Conversation
4 tasks
KepoParis
force-pushed
the
feat/environment-deletion-deployments-warning
branch
from
August 20, 2026 15:25
50555b4 to
5c0299f
Compare
KepoParis
marked this pull request as ready for review
August 20, 2026 15:25
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2517.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2472
Quel est le comportement actuel ?
La suppression d'un environnement supprime en cascade les déploiements qui lui sont rattachés, sans que l'utilisateur en soit averti dans la modale de confirmation.
Quel est le nouveau comportement ?
La modale de confirmation affiche un avertissement lorsque des déploiements sont liés : « Cet environnement est lié à N déploiement(s). Leur suppression sera également effectuée et est irréversible. » Aucun message si N vaut 0.
Le nombre est porté par la liste des environnements (
deploymentsCount, via un_countPrisma sur la relation) plutôt que calculé côté client à partir de la liste des déploiements : celle-ci exige la permissionListDeployments, qu'un utilisateur habilité à gérer les environnements (ManageEnvironments) n'a pas forcément. La route environnements est déjà protégée parListEnvironments, donc aucune permission supplémentaire n'est requise.Cette PR introduit-elle un breaking change ?
Non. Seule la réponse de
GET /api/v2/projects/:projectId/environmentsgagne un champdeploymentsCount; les autres routes sont inchangées.Autres informations
Tests unitaires serveur et client mis à jour et passants.