Repository navigation
Remove the manual pause/resume button from the Carousel - #307
Merged
Merged
Conversation
Closes #306. Client request: the visible pause/resume control the carousel rendered in its top-right corner while autoplay was running is no longer wanted. This button existed specifically to satisfy WCAG 2.2.2 (Pause, Stop, Hide) — removing it is a deliberate accessibility trade-off, not a bug fix, per that explicit request. The pause-on-hover/pause-on-focus behavior (data-pause-on-hover) is unaffected and stays as-is; only the visible manual control and the "manual" pause reason coordinating with it are gone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #306.
Client request: remove the visible pause/resume control the Carousel rendered in the top-right corner while autoplay was running.
Note: this button existed specifically to satisfy WCAG 2.2.2 (Pause, Stop, Hide) — removing it is a deliberate accessibility trade-off, not a bug fix, per the explicit request recorded in #306.
data-pause-on-hover) is unaffected and stays exactly as-is.hoverpause: falsestays on the Glide config since hover/focus pausing is still handled manually (unchanged from before), independent of this removal.Test plan
composer lintcleantests/js/carousel-accessibility.test.jsupdated: removed the 5 pause-button-specific tests, kept and adjusted the autoplay/reduced-motion and hover+focus coordination tests (now covering only those two reasons instead of three) — all 5 remaining tests pass🤖 Generated with Claude Code