Repository navigation
Fix CI not running on master: wrong branch filter + committed __pycache__ files - #5
Merged
Merged
Conversation
…unning) Agent-Logs-Url: https://github.com/chefgs/aws_boto3_scripts/sessions/38fc2286-f869-4bc3-9d8c-92e6666562df Co-authored-by: chefgs <7605658+chefgs@users.noreply.github.com>
…n on master Agent-Logs-Url: https://github.com/chefgs/aws_boto3_scripts/sessions/38fc2286-f869-4bc3-9d8c-92e6666562df Co-authored-by: chefgs <7605658+chefgs@users.noreply.github.com>
…index Agent-Logs-Url: https://github.com/chefgs/aws_boto3_scripts/sessions/033bd245-e72b-4ea8-afe0-e78973f6cea2 Co-authored-by: chefgs <7605658+chefgs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4 (cost calculator) replaced the unconditional
on: [push]trigger with a branch-filtered one targeting"main", but the repo's default branch ismaster. This silently stopped all CI runs — including the new cost unit tests — on every push to master. The same PR also rangit add .during development, which committed 68__pycache__/.pycfiles despite__pycache__/already being in.gitignore.Changes
CI trigger — Updated
.github/workflows/pythonapp.ymlto fire on bothmasterandmain:Untrack bytecode — Removed all 68 accidentally tracked
__pycache__/.pycfiles from the git index viagit rm --cached. The existing.gitignorerule (__pycache__/) now takes effect and prevents future recurrence.