SP-1173: extend CUI marking to --outputToJsonFile commands - #410
Merged
Dennis Woditsch (dwoditsch) merged 2 commits intoAug 13, 2026
Conversation
3 tasks
Dennis Woditsch (dwoditsch)
force-pushed
the
feat/SP-1173-cui-marking-output-to-json-file
branch
from
August 10, 2026 12:14
bd54a2a to
f484dbe
Compare
This was referenced Aug 10, 2026
Nikolai Fischer (nikolai-celonis)
approved these changes
Aug 10, 2026
Dennis Woditsch (dwoditsch)
marked this pull request as ready for review
August 11, 2026 05:26
Dennis Woditsch (dwoditsch)
requested review from
a team,
Dusan Radosavljevic (Dusan-r),
Ekta Dubey (EktaCelonis),
Ivan Gandacov (IvanGandacov) and
Oleg Goras (gorasoCelonis)
as code owners
August 11, 2026 05:26
3 tasks
Nikolai Fischer (nikolai-celonis)
previously approved these changes
Aug 11, 2026
Zgjim Haziri (ZgjimHaziri)
previously approved these changes
Aug 12, 2026
Ivan Gandacov (IvanGandacov)
previously approved these changes
Aug 13, 2026
Hubert Kulas (hkulas)
previously approved these changes
Aug 13, 2026
The five report and export writers behind --outputToJsonFile now hand their payload to CuiFileService and log the filename it returns, since marking renames the artifact to "CUI - <name>.zip". All five enclosing methods were already async, so no signatures change. The analyze action-flows spec stubbed axios.get wholesale, which swallowed the cover probe and returned an undefined status; it now mocks by URL so the cover endpoint keeps the default 204. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
One case per write site, asserting the logged filename is a classified archive holding the payload plus the cover sheet. The two report writers log under their own prefix rather than the shared download message. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Dennis Woditsch (dwoditsch)
dismissed stale reviews from Hubert Kulas (hkulas), Ivan Gandacov (IvanGandacov), Zgjim Haziri (ZgjimHaziri), and Nikolai Fischer (nikolai-celonis)
via
August 13, 2026 13:55
f9ab39c
Dennis Woditsch (dwoditsch)
force-pushed
the
feat/SP-1173-cui-marking-output-to-json-file
branch
from
August 13, 2026 13:56
f484dbe to
f9ab39c
Compare
|
Ivan Gandacov (IvanGandacov)
approved these changes
Aug 13, 2026
Kastriot Salihu (ksalihu)
approved these changes
Aug 13, 2026
Hubert Kulas (hkulas)
approved these changes
Aug 13, 2026
Dennis Woditsch (dwoditsch)
deleted the
feat/SP-1173-cui-marking-output-to-json-file
branch
August 13, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #407, which finished the
--jsonrow. This PR takes the next one: the reports and exports written behind-o, --outputToJsonFile.Scope: how the write is triggered
--jsonlistings and reportslist spaces,list packages--jsonlistings and reportslist assets/assignments/data-pools,config *,t2tc package list/diff,deployment *,asset-registry *-o, --outputToJsonFilereportsanalyze/import action-flows,export data-pool,import data-pools,t2tc package importreportconfig package export --zip,config branch export --zip,t2tc package export,export action-flows,pull packagepull asset/skill/data-pool/view-bookmarks/bookmarks,export bookmarksconfig package export,config branch export,t2tc package export --unzip--gitBranchvariantsconfig package export,config branch export,t2tc package exportt2tc package importis the odd one in this row: its report has no flag and is written unconditionally. It sits here because it is a report rather than an export artifact.Both open questions from #405 are still unaffected: how to mark an artifact that is already a zip, and what to do for directory output.
Relevant links
Checklist
Made with Cursor