removed old code - #1850
Merged
Merged
Conversation
pendingintent
approved these changes
Sep 3, 2026
OGarcia11
reviewed
Sep 3, 2026
OGarcia11
left a comment
OGarcia11
left a comment
Collaborator
There was a problem hiding this comment.
Flagging a couple of things before this merges — see inline comment.
Collaborator
There was a problem hiding this comment.
Removing generate_record_message and generate_single_error still leaves references to them in the test suite, which is why the test check is currently failing:
tests/unit/test_rules_engine.pystill asserts ongenerate_record_message_metadataandgenerate_single_error_metadatain the actions schema.tests/unit/test_utilities/test_rule_processor.pystill has a test case built aroundgenerate_record_message.
If these are truly dead/unmaintained actions, we'll need to update or remove those tests as part of this PR. But it's also worth double-checking there's no rule content elsewhere (e.g. in cdisc-open-rules) still invoking these actions by name — deleting an action that's still referenced by a published rule would break that rule at runtime, not just in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes 2 pieces of dead code in actions so as to prevent confusion with end users that these are maintained, valid actions.