Repository navigation
Bundle snappy-java in format-parquet plugin jar - #2021
Open
sahusanket wants to merge 1 commit into
Open
sahusanket wants to merge 1 commit into
sahusanket wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the snappy.version from 1.1.2 to 1.1.10.5 in the root pom.xml and adds the snappy-java dependency to the format-parquet module. Additionally, it introduces a new unit test testSnappyParquetWriteAndRead to verify the writing and reading of Parquet files using Snappy compression. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch pipelines writing or reading Snappy-compressed Parquet files fail at runtime with
ClassNotFoundException: org.xerial.snappy.Snappy.format-parquetinheritshadoop-commonatprovidedscope (depth 2 tosnappy-java), which wins Maven's nearest-dependency resolution overparquet-avro -> parquet-hadoop -> snappy-java(depth 3,compilescope). Becausemaven-bundle-pluginonly embedscompile-scope dependencies intolib/and CDAP'sFilterClassLoaderblocksorg.xerial.snappy.*from the parent Hadoop/Spark classloader,snappy-javais missing at runtime unless declared directly informat-parquet/pom.xml(this remains needed alongside #2017).Declare
org.xerial.snappy:snappy-javadirectly atcompilescope informat-parquet/pom.xmland bump<snappy.version>from1.1.2to1.1.10.5solib/snappy-java-1.1.10.5.jaris packaged in the plugin bundle.Tested with
ParquetInputFormatProviderTest#testSnappyParquetWriteAndRead,jar tfbundle verification, and an end-to-end GCS CSV-to-Snappy-Parquet Spark batch pipeline on Dataproc 2.3.