Repository navigation
Import jackson-bom 2.18.12 - #2016
deepika-lalwani123 wants to merge 4 commits into
Conversation
Image scanning of gcr.io/cdapio/cdap reports jline 3.9.0 and
jetty-http 9.4.51.v20230217 inside database-plugins-*.jar. dependency:tree
shows both come from hadoop-client 3.3.6 (compile scope) ->
hadoop-yarn-client 3.3.6 (jline 3.9.0, websocket-client -> jetty-client
-> jetty-http/-util/-io 9.4.51). The main code only uses
org.apache.hadoop.{conf,io,util,mapreduce,mapred.lib.db} classes, which
come from hadoop-common / hadoop-mapreduce-client-core that CDAP provides
at runtime, so hadoop-client is now provided. This also stops packaging
the rest of the Hadoop client tree (httpclient, commons-io 2.8.0,
commons-compress 1.21, reload4j, kerby, curator, jersey-client, jackson
jaxrs 2.12.7, ...) in the database-plugins jar.
The root-managed avro-mapred 1.11.4 pulled avro-ipc and avro-ipc-jetty,
which brought velocity-engine-core 2.3 (with commons-io 2.8.0) into the
format-avro jar (and through it format-parquet / google-cloud). No plugin
uses Avro IPC, so both are excluded.
Versions:
- hadoop-client 3.3.6: compile -> provided (database-plugins/pom.xml)
- avro-ipc, avro-ipc-jetty 1.11.4: excluded from avro-mapred (root
dependencyManagement)
Bugs: Plugins side done for jline b/578444907, b/578489244, b/578492108,
b/578644778, b/578663138 and jetty-http b/578515513.
Risk: low. No main-code change; Hadoop classes are supplied by CDAP.
Downstream projects that relied on database-plugins pulling hadoop-client
transitively at compile scope must declare it themselves (none in this
repo).
Testing: JDK 8, Checkstyle on (0 violations).
mvn -DcloudBuild clean verify -pl database-plugins,format-avro,format-parquet -am:
BUILD SUCCESS; hydrator-common, format-common, format-avro,
format-parquet and database-plugins unit tests pass (database-plugins: 35
run, 1 skipped: DBConnectorTest assumes live-DB system properties). dependency:tree
-Dincludes=org.jline,org.eclipse.jetty,org.apache.avro:avro-ipc*,org.apache.velocity
shows jline/jetty only at provided/test scope and no avro-ipc or velocity.
unzip -l database-plugins jar: lib/ now only has hydrator-common, guava,
opentracing-* and common-0.1.4 (no jline, jetty, hadoop-*); format-avro
jar has no avro-ipc / velocity. DB source/sink against real MySQL /
Postgres not run (needs a database).
Image scanning of gcr.io/cdapio/cdap reports CVEs in jars packaged by hydrator-plugins: log4j-core 2.20.0 / log4j-api 2.21.1 (format-xls, core-plugins via poi), bcprov-jdk15to18 1.84 (core-plugins), commons-io 2.5 (format-delimited), json-smart 2.2.1 (transform-plugins via json-path 2.2.0) and iq80 snappy 0.2 (format-orc via orc-core 1.1.0). The root POM now imports log4j-bom and manages commons-io, json-smart and iq80 snappy, so modules no longer pin their own versions. json-path stays on 2.2.0 (2.9 would pull json-smart 2.5.x). Versions: - log4j2 (log4j-core, log4j-api) 2.20.0 / 2.21.1 -> 2.25.5 (root log4j2.version, log4j-bom import; format-xls log4j-core.version removed) - bcprov-jdk15to18 1.84 -> 1.85 (core-plugins) - commons-io 2.5 / 2.15.0 -> 2.16.1 (root commons-io.version + managed entry; format-delimited property and core-plugins / format-xls pins removed) - json-smart 2.2.1 -> 2.4.10 (root json-smart.version, managed) - iq80 snappy 0.2 -> 0.5 (root iq80-snappy.version, managed) Bugs: Plugins side done for log4j-core b/578431300, b/578491647, b/578514361, b/578514875. iq80 snappy is rows only (b/578567520 stays open through the Platform leveldb exception). Risk: low-medium. Same-major bumps. log4j 2.25.x and commons-io 2.16.1 still run on Java 8. commons-compress (1.26.0 in core-plugins / format-xls) is not touched in this PR. Testing: JDK 8, Checkstyle on (0 violations). mvn -DcloudBuild clean verify -pl core-plugins,format-xls,format-delimited,transform-plugins,format-orc -am: BUILD SUCCESS; core-plugins 328 tests (2 skipped), transform-plugins 100 (1 skipped), format-xls / format-delimited / format-orc and dependencies all pass. dependency:tree -Dincludes=org.apache.logging.log4j,org.bouncycastle,commons-io,net.minidev:json-smart,org.iq80.snappy shows only log4j 2.25.5, bcprov-jdk15to18 1.85, commons-io 2.16.1, json-smart 2.4.10 and snappy 0.5 at compile scope (smbj's bcprov-jdk15on 1.70 is runtime scope and is not embedded). unzip -l of the built jars: core-plugins lib/ has bcprov-jdk15to18-1.85, commons-io-2.16.1, log4j-api-2.25.5; format-xls has log4j-core/-api 2.25.5, commons-io-2.16.1; format-delimited commons-io-2.16.1; transform-plugins json-smart-2.4.10; format-orc snappy-0.5. Excel / ORC / SFTP pipelines in a sandbox not run.
Image scanning of gcr.io/cdapio/cdap reports org.json:json 20160212 in
transform-plugins-*.jar (3 CVEs). transform-plugins is the only module
that uses ${json.version}; only XMLToJSON uses org.json (JSONObject,
XML.toJSONObject). Kept separate from the other minor bumps because
newer org.json changes behavior: numbers are parsed as BigDecimal /
BigInteger where needed, and XML.toJSONObject keeps strings with leading
zeros and some other values that the old version coerced.
Versions:
- org.json:json 20160212 -> 20260719 (root json.version)
Bugs: none closed alone in hydrator-plugins (the 3 org.json bugs close
once WR-3b and GC-3b also land).
Risk: medium. The XMLToJSON output can differ for numeric-looking
values (for example leading zeros and very large / high-precision
numbers).
Testing: JDK 8, Checkstyle on (0 violations).
mvn -DcloudBuild clean verify -pl transform-plugins -am: BUILD SUCCESS;
transform-plugins 100 tests pass (1 skipped, ValueMapperTest, as on
the HP-2a run), including XMLToJSONConverterTest (4), XMLParserTest (8),
XMLMultiParserTest (2), JSONParserTest (8), JSONFormatterTest (2).
unzip -l transform-plugins jar: lib/json-20260719.jar (no
json-20160212). A sandbox pipeline with XMLToJSON was not run.
Image scanning of gcr.io/cdapio/cdap reports jackson-databind 2.13.4.2 and jackson-core 2.13.4 / 2.14.3 in format-avro, format-parquet (also nested in google-cloud through format-avro) and spark-plugins jars. The root POM now imports com.fasterxml.jackson:jackson-bom so every jackson module (core, databind, annotations, module-scala for the Spark tests) resolves to one version; jackson.databind.version now points at the new jackson.version property, so existing module references keep working. Versions: - jackson (core, databind, annotations, modules) 2.13.4.2 / 2.14.3 -> 2.18.12 (root jackson.version + jackson-bom import) Bugs: none closed alone; the jackson rows still have a copy shaded in parquet-jackson 1.12.0 (HP-4) and in Platform / other plugins. Risk: medium. 2.15 added stream read limits (max string length 20M, nesting depth 1000, number length 1000) and 2.18 changed some property introspection. 2.18.x still runs on Java 8. The repo has no maven-shade-plugin usage, so the shade >= 3.5 rule does not apply. Testing: JDK 8, Checkstyle on (0 violations). mvn -DcloudBuild clean verify (whole reactor: 17 modules): BUILD SUCCESS; all unit tests pass (core-plugins 328 / 2 skipped, transform-plugins 100 / 1 skipped, database-plugins 35 / 1 skipped, spark-plugins, http-plugins, solrsearch-plugins, format-* modules). dependency:tree -Dincludes=com.fasterxml.jackson.core,com.fasterxml.jackson.module,com.fasterxml.jackson.dataformat shows only 2.18.12 at compile scope. unzip -l: format-avro, format-parquet and spark-plugins lib/ contain jackson-*-2.18.12 only (format-parquet still has parquet-jackson-1.12.0, fixed in HP-4). The submodules (google-cloud, kafka, azure, ...) are separate repos and are not built here (-DcloudBuild).
There was a problem hiding this comment.
Code Review
This pull request updates several dependency versions and configurations across multiple pom.xml files to standardize dependency management. It introduces a dependencyManagement section in the root pom.xml for libraries like Jackson, Log4j, and Commons IO, and adds necessary exclusions for avro-mapred. A critical issue was identified regarding a typo in the json.version property, which points to a non-existent future version.
| <zookeeper.version>3.4.5</zookeeper.version> | ||
| <json-path.version>2.2.0</json-path.version> | ||
| <json.version>20160212</json.version> | ||
| <json.version>20260719</json.version> |
There was a problem hiding this comment.
The version 20260719 for json.version appears to be a typo. The year 2026 is in the future, and this version does not exist in Maven Central. Please verify and use a valid version of org.json:json, such as 20231013 or 20240303.
| <json.version>20260719</json.version> | |
| <json.version>20231013</json.version> |
There was a problem hiding this comment.
False positive due to the bot's knowledge cutoff — org.json:json:20260719 is a valid published release on Maven Central (https://repo1.maven.org/maven2/org/json/json/20260719/). Keeping 20260719 (note: this change comes from stacked PR #2015).
Import jackson-bom 2.18.12
Repo: cdapio/hydrator-plugins
Branch: vuln/hp-3-jackson-bom → base develop (stacked)
Commit: d6115de
Part of the CVE fixes for the CDAP 6.11.2 patch release (container image scanning of gcr.io/cdapio/cdap).
Image scanning of gcr.io/cdapio/cdap reports jackson-databind 2.13.4.2
and jackson-core 2.13.4 / 2.14.3 in format-avro, format-parquet (also
nested in google-cloud through format-avro) and spark-plugins jars. The
root POM now imports com.fasterxml.jackson:jackson-bom so every jackson
module (core, databind, annotations, module-scala for the Spark tests)
resolves to one version; jackson.databind.version now points at the new
jackson.version property, so existing module references keep working.
Versions:
2.18.12 (root jackson.version + jackson-bom import)
Bugs: none closed alone; the jackson rows still have a copy shaded in
parquet-jackson 1.12.0 (#2017) and in the CDAP platform / other plugins.
Risk: medium. 2.15 added stream read limits (max string length 20M,
nesting depth 1000, number length 1000) and 2.18 changed some
property introspection. 2.18.x still runs on Java 8. The repo has no
maven-shade-plugin usage, so the shade >= 3.5 rule does not apply.
Testing: JDK 8, Checkstyle on (0 violations).
mvn -DcloudBuild clean verify (whole reactor: 17 modules): BUILD SUCCESS;
all unit tests pass (core-plugins 328 / 2 skipped, transform-plugins
100 / 1 skipped, database-plugins 35 / 1 skipped, spark-plugins,
http-plugins, solrsearch-plugins, format-* modules). dependency:tree
-Dincludes=com.fasterxml.jackson.core,com.fasterxml.jackson.module,com.fasterxml.jackson.dataformat
shows only 2.18.12 at compile scope. unzip -l: format-avro,
format-parquet and spark-plugins lib/ contain jackson-*-2.18.12 only
(format-parquet still has parquet-jackson-1.12.0, fixed in #2017).
The submodules (google-cloud, kafka, azure, ...) are separate repos and
are not built here (-DcloudBuild).