Skip to content

Upgrade low/medium risk dependencies with security fixes - #16269

Closed
deepika-lalwani123 wants to merge 1 commit into
developfrom
cve-low-medium-deps
Closed

deepika-lalwani123 wants to merge 1 commit into
developfrom
cve-low-medium-deps

Conversation

@deepika-lalwani123

Copy link
Copy Markdown
Contributor

Upgrade dependencies flagged by public image vulnerability scanning of gcr.io/cdapio/cdap to versions with fixes, staying within compatible release lines and Java 8:

  • jackson 2.15.1 -> 2.18.12
  • logback 1.2.11 -> 1.2.13
  • resteasy 3.0.8.Final -> 3.0.26.Final
  • quartz 2.2.0 -> 2.3.2 (drop QuartzSchedulerResources.setRunUpdateCheck, removed in 2.3 together with the update check itself)
  • jgit 5.9.0.202009080501-r -> 5.13.5.202508271544-r
  • commons-configuration2 2.10.1 -> 2.15.1, with commons-lang3 3.12.0 -> 3.20.0, commons-io 2.15.1 -> 2.22.0 and commons-text 1.15.0, which it requires
  • log4j-api/log4j-to-slf4j 2.20.0 -> 2.25.5
  • gson 2.8.6 -> 2.8.9 in cdap-kubernetes and cdap-credential-ext-gcp-wi
  • Manage transitive versions: commons-beanutils 1.11.0, jettison 1.5.7, httpclient 4.5.14, json-smart 2.5.2, jline 3.30.17

Upgrade dependencies flagged by public image vulnerability scanning of
gcr.io/cdapio/cdap to versions with fixes, staying within compatible
release lines and Java 8:

- jackson 2.15.1 -> 2.18.12
- logback 1.2.11 -> 1.2.13
- resteasy 3.0.8.Final -> 3.0.26.Final
- quartz 2.2.0 -> 2.3.2 (drop QuartzSchedulerResources.setRunUpdateCheck,
  removed in 2.3 together with the update check itself)
- jgit 5.9.0.202009080501-r -> 5.13.5.202508271544-r
- commons-configuration2 2.10.1 -> 2.15.1, with commons-lang3
  3.12.0 -> 3.20.0, commons-io 2.15.1 -> 2.22.0 and commons-text 1.15.0,
  which it requires
- log4j-api/log4j-to-slf4j 2.20.0 -> 2.25.5
- gson 2.8.6 -> 2.8.9 in cdap-kubernetes and cdap-credential-ext-gcp-wi
- Manage transitive versions: commons-beanutils 1.11.0, jettison 1.5.7,
  httpclient 4.5.14, json-smart 2.5.2, jline 3.30.17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various dependency versions across multiple POM files and pins several transitive dependencies to address security vulnerabilities. It also removes the update check configuration from the Quartz scheduler. However, multiple dependency versions specified in pom.xml (such as commons-io, commons-lang3, commons-configuration2, jackson, log4j, jgit, commons-beanutils, commons-text, and jline) do not exist in Maven Central and must be corrected to valid, stable versions to prevent build failures.

Comment thread pom.xml
<commons.cli.version>1.2</commons.cli.version>
<commons.collections.version>3.2.2</commons.collections.version>
<commons.io.version>2.15.1</commons.io.version>
<commons.io.version>2.22.0</commons.io.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 2.22.0 for commons-io does not exist in Maven Central. Please use a valid stable version such as 2.18.0 to avoid build failures.

Suggested change
<commons.io.version>2.22.0</commons.io.version>
<commons.io.version>2.18.0</commons.io.version>

Comment thread pom.xml
<bitbucket.jose4j.version>0.9.6</bitbucket.jose4j.version>
<commons.lang3.version>3.12.0</commons.lang3.version>
<commons-configuration2.version>2.10.1</commons-configuration2.version>
<commons.lang3.version>3.20.0</commons.lang3.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 3.20.0 for commons-lang3 does not exist in Maven Central. Please use a valid stable version such as 3.17.0 to avoid build failures.

Suggested change
<commons.lang3.version>3.20.0</commons.lang3.version>
<commons.lang3.version>3.17.0</commons.lang3.version>

Comment thread pom.xml
<commons.lang3.version>3.12.0</commons.lang3.version>
<commons-configuration2.version>2.10.1</commons-configuration2.version>
<commons.lang3.version>3.20.0</commons.lang3.version>
<commons-configuration2.version>2.15.1</commons-configuration2.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 2.15.1 for commons-configuration2 does not exist in Maven Central. Please use a valid stable version such as 2.11.0 to avoid build failures.

Suggested change
<commons-configuration2.version>2.15.1</commons-configuration2.version>
<commons-configuration2.version>2.11.0</commons-configuration2.version>

Comment thread pom.xml
<hadoop.version>3.3.6</hadoop.version>
<hsql.version>2.2.4</hsql.version>
<jackson.version>2.15.1</jackson.version>
<jackson.version>2.18.12</jackson.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 2.18.12 for jackson does not exist in Maven Central. Please use a valid stable version such as 2.18.2 to avoid build failures.

Suggested change
<jackson.version>2.18.12</jackson.version>
<jackson.version>2.18.2</jackson.version>

Comment thread pom.xml
<junit.version>4.11</junit.version>
<hamcrest.version>2.2</hamcrest.version>
<log4j2.slf4j.version>2.20.0</log4j2.slf4j.version>
<log4j2.slf4j.version>2.25.5</log4j2.slf4j.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 2.25.5 for log4j does not exist in Maven Central. Please use a valid stable version such as 2.24.3 to avoid build failures.

Suggested change
<log4j2.slf4j.version>2.25.5</log4j2.slf4j.version>
<log4j2.slf4j.version>2.24.3</log4j2.slf4j.version>

Comment thread pom.xml
<!-- Overwrite Apache Ivy version to 2.5.1 for remediating CVE-2022-37866-->
<ivy.version>2.5.1</ivy.version>
<jgit.version>5.9.0.202009080501-r</jgit.version>
<jgit.version>5.13.5.202508271544-r</jgit.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 5.13.5.202508271544-r for jgit does not exist in Maven Central. Please use a valid stable version such as 5.13.3.202401111515-r to avoid build failures.

Suggested change
<jgit.version>5.13.5.202508271544-r</jgit.version>
<jgit.version>5.13.3.202401111515-r</jgit.version>

Comment thread pom.xml
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<version>1.11.0</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 1.11.0 for commons-beanutils does not exist in Maven Central. Please use a valid stable version such as 1.9.4 to avoid build failures.

Suggested change
<version>1.11.0</version>
<version>1.9.4</version>

Comment thread pom.xml
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-text</artifactId>
<version>1.15.0</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 1.15.0 for commons-text does not exist in Maven Central. Please use a valid stable version such as 1.12.0 to avoid build failures.

Suggested change
<version>1.15.0</version>
<version>1.12.0</version>

Comment thread pom.xml
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline</artifactId>
<version>3.30.17</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 3.30.17 for jline does not exist in Maven Central. Please use a valid stable version such as 3.27.1 to avoid build failures.

Suggested change
<version>3.30.17</version>
<version>3.27.1</version>

@deepika-lalwani123 deepika-lalwani123 added the build Triggers github actions build label Oct 23, 2026
qrs.setThreadPool(threadPool);
qrs.setThreadExecutor(new DefaultThreadExecutor());
qrs.setJobStore(store);
qrs.setRunUpdateCheck(false);

@vsethi09 vsethi09 Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check implication of this removal.

  1. Is it safe to remove this?
  2. Would it be backward compatible and not cause any regression?

Comment thread pom.xml
<artifactId>commons-io</artifactId>
<version>${commons.io.version}</version>
</dependency>
<!-- Pin transitive dependencies to versions with security fixes. -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ....with security fixes can be removed as this comment may not be valid over a period of time.

@deepika-lalwani123

Copy link
Copy Markdown
Contributor Author

Superseded by the planned CVE-fix stack for 6.11.2. The low/medium dependency bumps are now split by change type: #16302 (patch bumps), #16307 + #16308 (jgit/gson/log4j2/commons-lang3 + quartz), #16311 (Hadoop transitive pins), plus #16303–#16312. Closing this PR in favor of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Triggers github actions build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants