Repository navigation
Upgrade Netty to 4.1.139.Final and manage it via netty-bom - #16268
Closed
deepika-lalwani123 wants to merge 1 commit into
Closed
deepika-lalwani123 wants to merge 1 commit into
deepika-lalwani123 wants to merge 1 commit into
Conversation
Bump netty.version from 4.1.75.Final to 4.1.139.Final and import io.netty:netty-bom in dependencyManagement instead of pinning only netty-buffer, netty-codec-http and netty-all. Previously, netty artifacts reached transitively (e.g. netty-handler and netty-resolver via io.cdap.http:netty-http in cdap-runtime-ext-dataproc) were not managed and still resolved to 4.1.75.Final. With the BOM, all io.netty artifacts in cdap-master and the runtime/credential/securestore extensions resolve to the same version. This fixes public image vulnerability findings for netty-* jars in CDAP master/UI lib and the extensions built from this repository. Plugin artifacts that bundle their own netty (kafka-plugins, google-cloud, wrangler, datastream-delta) and events-writer-extension need separate upgrades. This is an upgrade within the 4.1 line, which keeps API compatibility. Notable behavior changes since 4.1.75 are stricter HTTP header/chunk validation and HTTP/2 rapid-reset protection.
There was a problem hiding this comment.
Code Review
This pull request updates the netty.version from 4.1.75.Final to 4.1.139.Final in pom.xml and replaces individual Netty dependencies with the netty-bom import to ensure version consistency across transitive Netty artifacts. I have no feedback to provide as there are no review comments.
vsethi09
approved these changes
Oct 23, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump netty.version from 4.1.75.Final to 4.1.139.Final and import io.netty:netty-bom in dependencyManagement instead of pinning only netty-buffer, netty-codec-http and netty-all.
Previously, netty artifacts reached transitively (e.g. netty-handler and netty-resolver via io.cdap.http:netty-http in
cdap-runtime-ext-dataproc) were not managed and still resolved to 4.1.75.Final. With the BOM, all io.netty artifacts in cdap-master and the runtime/credential/securestore extensions resolve to the same version.
This fixes public image vulnerability findings for netty-* jars in CDAP master/UI lib and the extensions built from this repository. Plugin artifacts that bundle their own netty (kafka-plugins, google-cloud, wrangler, datastream-delta) and events-writer-extension need separate upgrades.
This is an upgrade within the 4.1 line, which keeps API compatibility. Notable behavior changes since 4.1.75 are stricter HTTP header/chunk validation and HTTP/2 rapid-reset protection.