Bump maplibre-gl from 5.24.0 to 6.4.1 in /CASCADE-app - #5
Merged
Cristian-Curaba merged 1 commit intoSep 11, 2026
Merged
Conversation
Fixes the Critical Dependabot alert (GHSA advisory, PR #5). The only breaking change that touches this codebase: maplibre-gl 6 dropped its default export in favor of named-exports-only. Both call sites used `import maplibregl from "maplibre-gl"` as a namespace (maplibregl.Map, new maplibregl.Map(...)) -- switched both to a namespace import (`import * as maplibregl`), which keeps every reference unchanged. Every maplibregl call in the codebase (new Map(), .on("load"), .resize(), .remove(), .setStyle()) is core API untouched since v1, so the risk here is the import change alone, not behavior. Verified against current main (this branch was stale, based on a much older commit -- rebuilt fresh rather than merged): - tsc --noEmit: 0 errors - vitest: 230/230 - eslint: 0 errors (same 17 pre-existing warnings) - madge --circular: none - next build: clean - docker build (both images) + compose config (dev + prod): clean Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Cristian-Curaba
force-pushed
the
dependabot/npm_and_yarn/CASCADE-app/maplibre-gl-6.4.1
branch
from
September 11, 2026 08:28
916ebaf to
5483d98
Compare
Cristian-Curaba
added a commit
that referenced
this pull request
Sep 11, 2026
Handles the merge step Dependabot's security updates leave to a human: once it opens a PR for a vulnerability fixed by a version bump, this approves and enables auto-merge -- but only for patch/minor semver bumps, and only once every existing CI check (.github/workflows/ci.yml) is green. Major bumps (see PR #5, maplibre-gl 5.x->6.x, currently failing CI) are deliberately left for a human. Requires the repo's "Allow auto-merge" setting (Settings > General > Pull Requests), which is currently off and could not be flipped via the API -- needs an org owner to enable it by hand. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Cristian-Curaba
deleted the
dependabot/npm_and_yarn/CASCADE-app/maplibre-gl-6.4.1
branch
September 11, 2026 08:36
Cristian-Curaba
added a commit
that referenced
this pull request
Sep 11, 2026
) * Disable maplibre-gl's own resize tracking (fixes zoom stretching the map) Regression from the 5.24.0 -> 6.4.1 bump (#5). maplibre-gl 6 added an internal ResizeObserver on the `container` option (_setupResizeObserver, new in this major version) that calls resize() + redraw() on its own. We pass the SAME element as container that useMapViewportSync CSS-transforms every frame for the zoom sync (translate + scale, to keep the background locked to React Flow's viewport without a jumpTo() per frame) -- and that hook already has its own ResizeObserver on that element, calling resize() explicitly at every point that matters: on load, on tile style change, and on a real container resize. Two independent resize-tracking paths racing on the one CSS-transformed element is what made zooming visibly stretch/narrow the map canvas instead of just scaling it smoothly. trackResize: false disables only maplibre's own new auto-resize path (confirmed its only consumer in the library). Nothing else depends on it -- our code already explicitly calls .resize() at every point maplibre's internal tracking would have. Verified: tsc 0 errors, 230/230 tests, eslint 0 new warnings, clean build. Visual confirmation (does zoom now scale smoothly) still needs an actual browser -- please check after pulling. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Fix blank geo map under maplibre-gl 6: serve its worker from public/ maplibre-gl 6 ships ESM-only and loads tile decoding into a Web Worker that imports a sibling chunk (maplibre-gl-shared.mjs) by relative path. Next.js — in both Turbopack and --webpack mode — emits that worker as a lone hashed asset without the sibling, so the worker throws on its first import. The map mounts and fires "load", but never requests a tile: a blank background, no console error, and the CSS-transform viewport sync left as the only thing moving (hence "zoom pans the window, not the map"). Follow the upstream Turbopack/Next.js recipe: copy both dist files into public/maplibre/ at predev/prebuild time (always matching the installed version) and point setWorkerUrl at the same-origin path. Caddy already allows worker-src 'self' and leaves /maplibre/* on no-cache, so an upgrade can't serve a stale worker. Also reverts the speculative trackResize:false from the previous commit — it addressed a hypothesis, not this cause, and maplibre's own resize tracking is harmless. Docs: architecture.md gains the build step and the version bump to 6. Ref: https://maplibre.org/maplibre-gl-js/docs/ → Installation → Turbopack Signed-off-by: Cristian Curaba <cristiancuraba00@gmail.com> --------- Signed-off-by: Cristian Curaba <cristiancuraba00@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps maplibre-gl from 5.24.0 to 6.4.1.
Release notes
Sourced from maplibre-gl's releases.
... (truncated)
Changelog
Sourced from maplibre-gl's changelog.
... (truncated)
Commits
37e08c1Bump js version to 6.4.1 (#8190)1da69f3fix: snapshot attributes in DOM.removeAttributes to avoid skipping them (#8189)ac8580bchore(deps): bump zensical/zensical from 0.0.53 to 0.0.54 (#8183)a7636f3chore(deps): bump the codeql-action group with 3 updates (#8181)18a2192chore(deps-dev): bump rolldown from 1.2.3 to 1.2.4 (#8180)740b106chore(deps-dev): bump globals from 17.9.0 to 17.11.0 (#8178)f6ac7bbchore(deps-dev): bump devtools-protocol from 0.0.1676914 to 0.0.1679354 (#8176)ef90e66fix: pass real globe transition progress to custom layers (#8169)4529c6eBump js version to 6.4.0 (#8171)73773c1fix: rounded corner spikes (#8155)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.