docs: add Triangle.heatmap examples (#704) - #1210
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 91 91
Lines 5401 5401
Branches 691 691
=======================================
Hits 4929 4929
Misses 338 338
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I think the average user will want to see actual heatmaps. It would be more valuable to not add any examples in the docstring instead, just a link to a notebook in the docs that actually have heatmap. |
Doctest cannot render a background gradient; the Triangle notebook already shows one. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Dropped the HTML doctests. The docstring now points at the existing rendered example in the Triangle user guide ( |
henrydingliu
left a comment
There was a problem hiding this comment.
validated link via PR build
|
@EKtheSage thanks! |
Summary of Changes
ExamplesforTriangle.heatmapinchainladder/core/display.py.cmap, and the multi-dimensionalValueError.Related GitHub Issue(s)
Additional Context for Reviewers
Bite-sized core-module follow-up for #704. Companions: slicing #1208, I/O #1209.
HTML output is asserted by type and by the presence of
background-colorrather than dumping the full markup.Checklist
Made with Cursor